third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2308353002: Replaced PassRefPtr copies with moves in Source/web and Source/wtf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2308353002: Replaced PassRefPtr copies with moves in Source/web and Source/wtf. (Closed)

Patch Set: Removed changes in HashMap.h which cause std::forward/std::move conflict Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index 5eaebb760d6b13c1356b85706fe4f3579a97e8d9..f081d46663df622becb2c4881350200450e9306e 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -716,7 +716,7 @@ void ChromeClientImpl::openFileChooser(LocalFrame* frame, PassRefPtr<FileChooser

params.needLocalPath = fileChooser->settings().allowsDirectoryUpload;

params.requestor = frame->document()->url();

- WebFileChooserCompletionImpl* chooserCompletion = new WebFileChooserCompletionImpl(fileChooser);

+ WebFileChooserCompletionImpl* chooserCompletion = new WebFileChooserCompletionImpl(std::move(fileChooser));

if (client->runFileChooser(params, chooserCompletion))

return;

// Choosing failed, so do callback with an empty list.

« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/typed_arrays/Float32Array.h » ('j') | no next file with comments »