third_party/WebKit/Source/wtf/typed_arrays/Uint8Array.h - Issue 2308353002: Replaced PassRefPtr copies with moves in Source/web and Source/wtf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/typed_arrays/Uint8Array.h

Issue 2308353002: Replaced PassRefPtr copies with moves in Source/web and Source/wtf. (Closed)

Patch Set: Removed changes in HashMap.h which cause std::forward/std::move conflict Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/typed_arrays/Uint8Array.h

diff --git a/third_party/WebKit/Source/wtf/typed_arrays/Uint8Array.h b/third_party/WebKit/Source/wtf/typed_arrays/Uint8Array.h

index 16df128bec03cdf59084da62fbed2dd14b01c122..9b2ce6935d4ad17db723ad1387bcc081a5543ce6 100644

--- a/third_party/WebKit/Source/wtf/typed_arrays/Uint8Array.h

+++ b/third_party/WebKit/Source/wtf/typed_arrays/Uint8Array.h

@@ -65,11 +65,11 @@ PassRefPtr<Uint8Array> Uint8Array::create(const unsigned char* array, unsigned l

PassRefPtr<Uint8Array> Uint8Array::create(PassRefPtr<ArrayBuffer> buffer, unsigned byteOffset, unsigned length)

{

- return TypedArrayBase<unsigned char>::create<Uint8Array>(buffer, byteOffset, length);

+ return TypedArrayBase<unsigned char>::create<Uint8Array>(std::move(buffer), byteOffset, length);

}

Uint8Array::Uint8Array(PassRefPtr<ArrayBuffer> buffer, unsigned byteOffset, unsigned length)

-: IntegralTypedArrayBase<unsigned char>(buffer, byteOffset, length)

+: IntegralTypedArrayBase<unsigned char>(std::move(buffer), byteOffset, length)

{

}