Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2308353002: Replaced PassRefPtr copies with moves in Source/web and Source/wtf. (Closed)
Patch Set: Removed changes in HashMap.h which cause std::forward/std::move conflict Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/typed_arrays/Float32Array.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 698 matching lines...) Expand 10 before | Expand all | Expand 10 after
709 params.multiSelect = fileChooser->settings().allowsMultipleFiles; 709 params.multiSelect = fileChooser->settings().allowsMultipleFiles;
710 params.directory = fileChooser->settings().allowsDirectoryUpload; 710 params.directory = fileChooser->settings().allowsDirectoryUpload;
711 params.acceptTypes = fileChooser->settings().acceptTypes(); 711 params.acceptTypes = fileChooser->settings().acceptTypes();
712 params.selectedFiles = fileChooser->settings().selectedFiles; 712 params.selectedFiles = fileChooser->settings().selectedFiles;
713 if (params.selectedFiles.size() > 0) 713 if (params.selectedFiles.size() > 0)
714 params.initialValue = params.selectedFiles[0]; 714 params.initialValue = params.selectedFiles[0];
715 params.useMediaCapture = fileChooser->settings().useMediaCapture; 715 params.useMediaCapture = fileChooser->settings().useMediaCapture;
716 params.needLocalPath = fileChooser->settings().allowsDirectoryUpload; 716 params.needLocalPath = fileChooser->settings().allowsDirectoryUpload;
717 params.requestor = frame->document()->url(); 717 params.requestor = frame->document()->url();
718 718
719 WebFileChooserCompletionImpl* chooserCompletion = new WebFileChooserCompleti onImpl(fileChooser); 719 WebFileChooserCompletionImpl* chooserCompletion = new WebFileChooserCompleti onImpl(std::move(fileChooser));
720 if (client->runFileChooser(params, chooserCompletion)) 720 if (client->runFileChooser(params, chooserCompletion))
721 return; 721 return;
722 // Choosing failed, so do callback with an empty list. 722 // Choosing failed, so do callback with an empty list.
723 chooserCompletion->didChooseFile(WebVector<WebString>()); 723 chooserCompletion->didChooseFile(WebVector<WebString>());
724 } 724 }
725 725
726 void ChromeClientImpl::enumerateChosenDirectory(FileChooser* fileChooser) 726 void ChromeClientImpl::enumerateChosenDirectory(FileChooser* fileChooser)
727 { 727 {
728 WebViewClient* client = m_webView->client(); 728 WebViewClient* client = m_webView->client();
729 if (!client) 729 if (!client)
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
1134 ScreenOrientationController::provideTo(frame, client ? client->webScreenOrie ntationClient() : nullptr); 1134 ScreenOrientationController::provideTo(frame, client ? client->webScreenOrie ntationClient() : nullptr);
1135 if (RuntimeEnabledFeatures::presentationEnabled()) 1135 if (RuntimeEnabledFeatures::presentationEnabled())
1136 PresentationController::provideTo(frame, client ? client->presentationCl ient() : nullptr); 1136 PresentationController::provideTo(frame, client ? client->presentationCl ient() : nullptr);
1137 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) 1137 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())
1138 provideAudioOutputDeviceClientTo(frame, AudioOutputDeviceClientImpl::cre ate()); 1138 provideAudioOutputDeviceClientTo(frame, AudioOutputDeviceClientImpl::cre ate());
1139 if (RuntimeEnabledFeatures::installedAppEnabled()) 1139 if (RuntimeEnabledFeatures::installedAppEnabled())
1140 InstalledAppController::provideTo(frame, client ? client->installedAppCl ient() : nullptr); 1140 InstalledAppController::provideTo(frame, client ? client->installedAppCl ient() : nullptr);
1141 } 1141 }
1142 1142
1143 } // namespace blink 1143 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/typed_arrays/Float32Array.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698