Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2305383002: [turbofan] Nuke the context types. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Nuke the context types. Those have been effectively unused for quite a while now, and we don't see any use in having them around. Actually it'd be way more consistent and simpler to just use OtherInternal as type for contexts instead. R=mvstanton@chromium.org BUG=v8:5267, v8:5270 Committed: https://crrev.com/b5f60820acc51075ac139037788d52951a20ff84 Cr-Commit-Position: refs/heads/master@{#39166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -124 lines) Patch
M src/compiler/typer.cc View 3 chunks +13 lines, -26 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/types.h View 5 chunks +2 lines, -33 lines 0 comments Download
M src/types.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M test/cctest/test-types.cc View 4 chunks +1 line, -41 lines 0 comments Download
M test/cctest/types-fuzz.h View 2 chunks +3 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-05 12:11:19 UTC) #1
Benedikt Meurer
Hey Michael, Moar cleanup on the type system. Please take a look. Thanks, Benedikt
4 years, 3 months ago (2016-09-05 12:11:46 UTC) #4
mvstanton
Nice to see it rapidly getting simpler. LGTM.
4 years, 3 months ago (2016-09-05 12:13:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305383002/1
4 years, 3 months ago (2016-09-05 12:15:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 12:40:47 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 12:41:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5f60820acc51075ac139037788d52951a20ff84
Cr-Commit-Position: refs/heads/master@{#39166}

Powered by Google App Engine
This is Rietveld 408576698