Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/compiler/verifier.cc

Issue 2305383002: [turbofan] Nuke the context types. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 0c1f919db5ea03120f40019a8d7bee611f7496ee..0c214fc4d5566572608b441c060fa47a9605ecbf 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -610,10 +610,10 @@ void Verifier::Visitor::Check(Node* node) {
case IrOpcode::kJSCreateScriptContext: {
// Type is Context, and operand is Internal.
Node* context = NodeProperties::GetContextInput(node);
- // TODO(rossberg): This should really be Is(Internal), but the typer
- // currently can't do backwards propagation.
- CheckTypeMaybe(context, Type::Internal());
- if (typing == TYPED) CHECK(NodeProperties::GetType(node)->IsContext());
+ // TODO(bmeurer): This should say CheckTypeIs, but we don't have type
+ // OtherInternal on certain contexts, i.e. those from OsrValue inputs.
+ CheckTypeMaybe(context, Type::OtherInternal());
+ CheckTypeIs(node, Type::OtherInternal());
break;
}
« no previous file with comments | « src/compiler/typer.cc ('k') | src/types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698