Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: src/compiler/verifier.cc

Issue 2305383002: [turbofan] Nuke the context types. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/types.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 592 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 // Type is empty. 603 // Type is empty.
604 CheckNotTyped(node); 604 CheckNotTyped(node);
605 break; 605 break;
606 case IrOpcode::kJSCreateFunctionContext: 606 case IrOpcode::kJSCreateFunctionContext:
607 case IrOpcode::kJSCreateCatchContext: 607 case IrOpcode::kJSCreateCatchContext:
608 case IrOpcode::kJSCreateWithContext: 608 case IrOpcode::kJSCreateWithContext:
609 case IrOpcode::kJSCreateBlockContext: 609 case IrOpcode::kJSCreateBlockContext:
610 case IrOpcode::kJSCreateScriptContext: { 610 case IrOpcode::kJSCreateScriptContext: {
611 // Type is Context, and operand is Internal. 611 // Type is Context, and operand is Internal.
612 Node* context = NodeProperties::GetContextInput(node); 612 Node* context = NodeProperties::GetContextInput(node);
613 // TODO(rossberg): This should really be Is(Internal), but the typer 613 // TODO(bmeurer): This should say CheckTypeIs, but we don't have type
614 // currently can't do backwards propagation. 614 // OtherInternal on certain contexts, i.e. those from OsrValue inputs.
615 CheckTypeMaybe(context, Type::Internal()); 615 CheckTypeMaybe(context, Type::OtherInternal());
616 if (typing == TYPED) CHECK(NodeProperties::GetType(node)->IsContext()); 616 CheckTypeIs(node, Type::OtherInternal());
617 break; 617 break;
618 } 618 }
619 619
620 case IrOpcode::kJSCallConstruct: 620 case IrOpcode::kJSCallConstruct:
621 case IrOpcode::kJSConvertReceiver: 621 case IrOpcode::kJSConvertReceiver:
622 // Type is Receiver. 622 // Type is Receiver.
623 CheckTypeIs(node, Type::Receiver()); 623 CheckTypeIs(node, Type::Receiver());
624 break; 624 break;
625 case IrOpcode::kJSCallFunction: 625 case IrOpcode::kJSCallFunction:
626 case IrOpcode::kJSCallRuntime: 626 case IrOpcode::kJSCallRuntime:
(...skipping 954 matching lines...) Expand 10 before | Expand all | Expand 10 after
1581 replacement->op()->EffectOutputCount() > 0); 1581 replacement->op()->EffectOutputCount() > 0);
1582 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1582 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1583 replacement->opcode() == IrOpcode::kFrameState); 1583 replacement->opcode() == IrOpcode::kFrameState);
1584 } 1584 }
1585 1585
1586 #endif // DEBUG 1586 #endif // DEBUG
1587 1587
1588 } // namespace compiler 1588 } // namespace compiler
1589 } // namespace internal 1589 } // namespace internal
1590 } // namespace v8 1590 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698