Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2310923002: [turbofan] Also nuke Array and Function types. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also nuke Array and Function types. We used to have Array types for typed arrays in asm.js at some point, but had to change that quite some time ago already. And Function types were mostly used for the CallInterfaceDescriptor (and the code-stub.js experiment), but are also unusedn nowadays. R=mvstanton@chromium.org BUG=v8:5267, v8:5270 Committed: https://crrev.com/68b47f5e0f02a736ddd3ae3e210957d947f7516c Cr-Commit-Position: refs/heads/master@{#39168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -415 lines) Patch
M src/compiler/type-cache.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/types.h View 6 chunks +0 lines, -107 lines 0 comments Download
M src/types.cc View 3 chunks +0 lines, -36 lines 0 comments Download
M test/cctest/test-types.cc View 10 chunks +1 line, -205 lines 0 comments Download
M test/cctest/types-fuzz.h View 4 chunks +0 lines, -50 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-05 12:22:45 UTC) #1
Benedikt Meurer
Hey Michael, And even more dead code. Please take a look. Thanks, Benedikt
4 years, 3 months ago (2016-09-05 12:23:10 UTC) #4
mvstanton
Most excellent. LGTM.
4 years, 3 months ago (2016-09-05 12:37:48 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2305383002 Patch 1). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-05 12:38:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310923002/1
4 years, 3 months ago (2016-09-05 13:01:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 13:03:35 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 13:03:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68b47f5e0f02a736ddd3ae3e210957d947f7516c
Cr-Commit-Position: refs/heads/master@{#39168}

Powered by Google App Engine
This is Rietveld 408576698