Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2302973002: Refactor post requests, implement bot cancel/terminate (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@basic-layout
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Refactor post requests, implement bot cancel/terminate There is a prompt before the delete/cancel goes through. Tasks that fail are highlighted red, tasks with BOT_DIED are grey, and the refresh button also works. BUG=631047 Committed: https://github.com/luci/luci-py/commit/d145f64ccb1486ec38d4665b87284fe38b62bcfd

Patch Set 1 #

Patch Set 2 : Add docs #

Patch Set 3 : rebase #

Total comments: 5

Patch Set 4 : Build using new skia-common-js #

Total comments: 4

Patch Set 5 : Address comments #

Total comments: 9

Patch Set 6 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+781 lines, -64 lines) Patch
M appengine/swarming/elements/build/elements.html View 1 2 3 4 5 16 chunks +595 lines, -29 lines 0 comments Download
M appengine/swarming/elements/build/js/js.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/package.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/botpage/bot-page.html View 1 2 3 4 5 14 chunks +82 lines, -10 lines 0 comments Download
M appengine/swarming/elements/res/imp/botpage/bot-page-demo.html View 3 chunks +28 lines, -3 lines 0 comments Download
A appengine/swarming/elements/res/imp/common/error-toast.html View 1 2 3 4 5 1 chunk +56 lines, -0 lines 0 comments Download
M appengine/swarming/elements/res/imp/tasklist/task-list.html View 1 2 3 4 3 chunks +3 lines, -20 lines 0 comments Download
M appengine/swarming/elements/res/js/common.js View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 28 (9 generated)
kjlubick
The prompt: https://screenshot.googleplex.com/qx9MGK1EnCt The toast after completion: https://screenshot.googleplex.com/47pwic6DVv1 It's live on https://2316-bae452c-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com, but only admins ...
4 years, 3 months ago (2016-09-01 18:50:12 UTC) #2
kjlubick
PTAL
4 years, 3 months ago (2016-09-02 17:09:55 UTC) #4
jcgregorio
https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html File appengine/swarming/elements/res/imp/common/common-behavior.html (right): https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html#newcode71 appengine/swarming/elements/res/imp/common/common-behavior.html:71: So there's already a similar solution that we have ...
4 years, 3 months ago (2016-09-02 18:31:22 UTC) #5
kjlubick
https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html File appengine/swarming/elements/res/imp/common/common-behavior.html (right): https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html#newcode71 appengine/swarming/elements/res/imp/common/common-behavior.html:71: On 2016/09/02 at 18:31:22, jcgregorio wrote: > So there's ...
4 years, 3 months ago (2016-09-06 13:06:31 UTC) #6
jcgregorio
https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html File appengine/swarming/elements/res/imp/common/common-behavior.html (right): https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html#newcode71 appengine/swarming/elements/res/imp/common/common-behavior.html:71: On 2016/09/06 at 13:06:31, kjlubick wrote: > On 2016/09/02 ...
4 years, 3 months ago (2016-09-06 15:16:53 UTC) #7
kjlubick
https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html File appengine/swarming/elements/res/imp/common/common-behavior.html (right): https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html#newcode71 appengine/swarming/elements/res/imp/common/common-behavior.html:71: On 2016/09/06 at 15:16:53, jcgregorio wrote: > On 2016/09/06 ...
4 years, 3 months ago (2016-09-06 15:26:50 UTC) #8
jcgregorio
https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html File appengine/swarming/elements/res/imp/common/common-behavior.html (right): https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html#newcode71 appengine/swarming/elements/res/imp/common/common-behavior.html:71: On 2016/09/06 at 15:26:50, kjlubick wrote: > On 2016/09/06 ...
4 years, 3 months ago (2016-09-06 15:33:33 UTC) #9
kjlubick
On 2016/09/06 at 15:33:33, jcgregorio wrote: > https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html > File appengine/swarming/elements/res/imp/common/common-behavior.html (right): > > https://codereview.chromium.org/2302973002/diff/40001/appengine/swarming/elements/res/imp/common/common-behavior.html#newcode71 ...
4 years, 3 months ago (2016-09-06 20:19:30 UTC) #10
jcgregorio
https://codereview.chromium.org/2302973002/diff/60001/appengine/swarming/elements/res/imp/common/common-behavior.html File appengine/swarming/elements/res/imp/common/common-behavior.html (right): https://codereview.chromium.org/2302973002/diff/60001/appengine/swarming/elements/res/imp/common/common-behavior.html#newcode74 appengine/swarming/elements/res/imp/common/common-behavior.html:74: _postWithToast: function(url, msg, auth_headers) { Now that you are ...
4 years, 3 months ago (2016-09-06 20:40:56 UTC) #11
kjlubick
https://codereview.chromium.org/2302973002/diff/60001/appengine/swarming/elements/res/imp/common/common-behavior.html File appengine/swarming/elements/res/imp/common/common-behavior.html (right): https://codereview.chromium.org/2302973002/diff/60001/appengine/swarming/elements/res/imp/common/common-behavior.html#newcode74 appengine/swarming/elements/res/imp/common/common-behavior.html:74: _postWithToast: function(url, msg, auth_headers) { On 2016/09/06 at 20:40:56, ...
4 years, 3 months ago (2016-09-07 12:00:21 UTC) #13
jcgregorio
LGTM, with a few blank line nits. https://codereview.chromium.org/2302973002/diff/80001/appengine/swarming/elements/res/imp/botpage/bot-page.html File appengine/swarming/elements/res/imp/botpage/bot-page.html (right): https://codereview.chromium.org/2302973002/diff/80001/appengine/swarming/elements/res/imp/botpage/bot-page.html#newcode83 appengine/swarming/elements/res/imp/botpage/bot-page.html:83: .dead, .bot_died ...
4 years, 3 months ago (2016-09-07 12:12:48 UTC) #14
kjlubick
https://codereview.chromium.org/2302973002/diff/80001/appengine/swarming/elements/res/imp/botpage/bot-page.html File appengine/swarming/elements/res/imp/botpage/bot-page.html (right): https://codereview.chromium.org/2302973002/diff/80001/appengine/swarming/elements/res/imp/botpage/bot-page.html#newcode83 appengine/swarming/elements/res/imp/botpage/bot-page.html:83: .dead, .bot_died { On 2016/09/07 at 12:12:48, jcgregorio wrote: ...
4 years, 3 months ago (2016-09-07 12:36:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302973002/100001
4 years, 3 months ago (2016-09-07 12:36:46 UTC) #18
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-07 12:36:50 UTC) #20
KevinL
lgtm
4 years, 3 months ago (2016-09-07 12:36:55 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302973002/100001
4 years, 3 months ago (2016-09-07 12:37:03 UTC) #24
stephana
On 2016/09/07 12:12:48, jcgregorio wrote: > LGTM, with a few blank line nits. > > ...
4 years, 3 months ago (2016-09-07 12:38:19 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://github.com/luci/luci-py/commit/d145f64ccb1486ec38d4665b87284fe38b62bcfd
4 years, 3 months ago (2016-09-07 12:40:25 UTC) #27
jcgregorio
4 years, 3 months ago (2016-09-07 12:41:21 UTC) #28
Message was sent while issue was closed.
https://codereview.chromium.org/2302973002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botpage/bot-page.html (right):

https://codereview.chromium.org/2302973002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page.html:83: .dead, .bot_died {
On 2016/09/07 at 12:36:38, kjlubick wrote:
> On 2016/09/07 at 12:12:48, jcgregorio wrote:
> > Each class should be on a new line:
> > 
> > .dead,
> > .bot_died {
> > 
> > Here and above for .quarantined.
> 
> Done.  Should we add this to the style guide?

Sure.

Powered by Google App Engine
This is Rietveld 408576698