Give error-toast a duration argument

Give error-toast a duration argument

Should push to skia-common-js 1.2.0

BUG=skia:

Committed: https://skia.googlesource.com/buildbot/+/e2d07ec06250b802ae28013c88f8d277c93ebb7d

[kjlubick, 2016-09-06 20:01:55]

Description was changed from

==========
Give error-toast a duration argument

BUG=skia:
==========

to

==========
Give error-toast a duration argument

Should push to skia-common-js 1.2.0

BUG=skia:
==========

[kjlubick, 2016-09-06 20:01:55]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com

[jcgregorio, 2016-09-06 20:37:01]

https://codereview.chromium.org/2309423004/diff/1/res/imp/error-toast-sk.html
File res/imp/error-toast-sk.html (right):

https://codereview.chromium.org/2309423004/diff/1/res/imp/error-toast-sk.html...
res/imp/error-toast-sk.html:11: defaults to 10000 (10s)
Integer, the number of ms to display or 0 for indefinitely.
               Defaults to 10000 (10s).

https://codereview.chromium.org/2309423004/diff/1/res/imp/error-toast-sk.html...
res/imp/error-toast-sk.html:39: this.$.toast.duration = duration;
this.$.toast.duration = (e.detail.duration === undefined ? 10000 :
e.detail.duration);

https://codereview.chromium.org/2309423004/diff/1/res/js/common.js
File res/js/common.js (right):

https://codereview.chromium.org/2309423004/diff/1/res/js/common.js#newcode79
res/js/common.js:79: detail.duration = duration;
Just use:

  detail.duration = duration;

Since undefined is a valid value to pass in the event.

[kjlubick, 2016-09-06 20:39:23]

The CQ bit was checked by kjlubick@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 20:39:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjlubick, 2016-09-06 20:39:38]

https://codereview.chromium.org/2309423004/diff/1/res/imp/error-toast-sk.html
File res/imp/error-toast-sk.html (right):

https://codereview.chromium.org/2309423004/diff/1/res/imp/error-toast-sk.html...
res/imp/error-toast-sk.html:11: defaults to 10000 (10s)
On 2016/09/06 at 20:37:01, jcgregorio wrote:
> Integer, the number of ms to display or 0 for indefinitely.
>                Defaults to 10000 (10s).

Done.

https://codereview.chromium.org/2309423004/diff/1/res/imp/error-toast-sk.html...
res/imp/error-toast-sk.html:39: this.$.toast.duration = duration;
On 2016/09/06 at 20:37:01, jcgregorio wrote:
> this.$.toast.duration = (e.detail.duration === undefined ? 10000 :
e.detail.duration);

Done.

https://codereview.chromium.org/2309423004/diff/1/res/js/common.js
File res/js/common.js (right):

https://codereview.chromium.org/2309423004/diff/1/res/js/common.js#newcode79
res/js/common.js:79: detail.duration = duration;
On 2016/09/06 at 20:37:01, jcgregorio wrote:
> Just use:
> 
>   detail.duration = duration;
> 
> Since undefined is a valid value to pass in the event.

Done.

[jcgregorio, 2016-09-06 20:41:27]

lgtm

[commit-bot: I haz the power, 2016-09-06 20:46:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 20:46:43]

Dry run: This issue passed the CQ dry run.

[kjlubick, 2016-09-06 21:28:08]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-09-06 21:28:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:28:30]

Description was changed from

==========
Give error-toast a duration argument

Should push to skia-common-js 1.2.0

BUG=skia:
==========

to

==========
Give error-toast a duration argument

Should push to skia-common-js 1.2.0

BUG=skia:

Committed:
https://skia.googlesource.com/buildbot/+/e2d07ec06250b802ae28013c88f8d277c93e...
==========

[commit-bot: I haz the power, 2016-09-06 21:28:31]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/e2d07ec06250b802ae28013c88f8d277c93e...