Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2309423004: Give error-toast a duration argument (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Give error-toast a duration argument Should push to skia-common-js 1.2.0 BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/e2d07ec06250b802ae28013c88f8d277c93ebb7d

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M res/imp/error-toast-sk.html View 1 3 chunks +6 lines, -1 line 0 comments Download
M res/js/common.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
kjlubick
4 years, 3 months ago (2016-09-06 20:12:29 UTC) #3
jcgregorio
https://codereview.chromium.org/2309423004/diff/1/res/imp/error-toast-sk.html File res/imp/error-toast-sk.html (right): https://codereview.chromium.org/2309423004/diff/1/res/imp/error-toast-sk.html#newcode11 res/imp/error-toast-sk.html:11: defaults to 10000 (10s) Integer, the number of ms ...
4 years, 3 months ago (2016-09-06 20:37:01 UTC) #4
kjlubick
https://codereview.chromium.org/2309423004/diff/1/res/imp/error-toast-sk.html File res/imp/error-toast-sk.html (right): https://codereview.chromium.org/2309423004/diff/1/res/imp/error-toast-sk.html#newcode11 res/imp/error-toast-sk.html:11: defaults to 10000 (10s) On 2016/09/06 at 20:37:01, jcgregorio ...
4 years, 3 months ago (2016-09-06 20:39:38 UTC) #7
jcgregorio
lgtm
4 years, 3 months ago (2016-09-06 20:41:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309423004/20001
4 years, 3 months ago (2016-09-06 21:28:17 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 21:28:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/e2d07ec06250b802ae28013c88f8d277c93e...

Powered by Google App Engine
This is Rietveld 408576698