Introduce new bot-page UI

Introduce new bot-page UI

The bot page is relatively simple (compared to the dynamic tables and
query-able filters used by bot-list and task-list)

It shows the bot's dimensions and other pertinent data.  There are buttons
for doing some bot maintenance (e.g. deleting dead bots), but those don't
quite work yet - next CL should add it.

In the demo code, you can view test-bot-001, 002 and 003 to see a normal
bot, a quarantined bot and a dead bot respectively.

The state is currently just a pretty printed version of the state object
that comes with the bot.  Perhaps in the future, important data from there
(like devices) can be pulled out and shown more easily.

BUG=631047
Committed: https://github.com/luci/luci-py/commit/0f81b3641969489e5475701bc488f85d08cf29b3

[kjlubick, 2016-08-31 19:34:12]

Description was changed from

==========
Introduce new bot-page UI

BUG=631047
==========

to

==========
Introduce new bot-page UI

The bot page is relatively simple (compared to the dynamic tables and query-able
filters used by bot-list and task-list)

It shows the bot's dimensions and other pertinent data.  There are buttons for
doing some bot maintenance (e.g. deleting dead bots), but those don't quite work
yet - next CL should add it.

In the demo code, you can view test-bot-001, 002 and 003 to see a normal bot, a
quarantined bot and a dead bot respectively.

The state is currently just a pretty printed version of the state object that
comes with the bot.  Perhaps in the future, important data from there (like
devices) can be pulled out and shown more easily.

BUG=631047
==========

[kjlubick, 2016-08-31 19:34:13]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-08-31 19:36:13]

Live at
https://2316-bae452c-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newu...

Normal display: 
https://screenshot.googleplex.com/20ykWR6eisc

Clicking on events:
https://screenshot.googleplex.com/FPYndzzhzgV

Events without messages are hidden unless you click "Show all events"
https://screenshot.googleplex.com/vsUALqxmyyh

State is not super fancy, but hidden by default:
https://screenshot.googleplex.com/t1zpXPgsgrY

Quarantined bots announce why they are quarantined:
https://screenshot.googleplex.com/BxA32R6jUY2

Dead bots can be deleted by admins:
https://screenshot.googleplex.com/00fDm9VKbfW

[kjlubick, 2016-08-31 19:38:28]

Description was changed from

==========
Introduce new bot-page UI

The bot page is relatively simple (compared to the dynamic tables and query-able
filters used by bot-list and task-list)

It shows the bot's dimensions and other pertinent data.  There are buttons for
doing some bot maintenance (e.g. deleting dead bots), but those don't quite work
yet - next CL should add it.

In the demo code, you can view test-bot-001, 002 and 003 to see a normal bot, a
quarantined bot and a dead bot respectively.

The state is currently just a pretty printed version of the state object that
comes with the bot.  Perhaps in the future, important data from there (like
devices) can be pulled out and shown more easily.

BUG=631047
==========

to

==========
Introduce new bot-page UI

The bot page is relatively simple (compared to the dynamic tables and
query-able filters used by bot-list and task-list)

It shows the bot's dimensions and other pertinent data.  There are buttons
for doing some bot maintenance (e.g. deleting dead bots), but those don't
quite work yet - next CL should add it.

In the demo code, you can view test-bot-001, 002 and 003 to see a normal
bot, a quarantined bot and a dead bot respectively.

The state is currently just a pretty printed version of the state object
that comes with the bot.  Perhaps in the future, important data from there
(like devices) can be pulled out and shown more easily.

BUG=631047
==========

[stephana, 2016-09-01 15:16:18]

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botpage/bot-page-data.html (right):

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:123: lastRequest
= setTimeout(function(){
IMO the Polymer async method is preferrable, i.e. 

 ... this.async(function() {
 .... 

it avoids having to bind 'this' and is in sync with Polymer's redraw cycles,etc.

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:165: // locale
time.
This seems something that the Date object should provide.
Shouldn't something like bot[time].toString() give you the same results you
would get from this call.

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:213: var timeZone
= str.substring(str.indexOf("("))
Same as above. Instead of copying the code there should be a shared function
that returns a date object in the desired format.

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botpage/bot-page.html (right):

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page.html:341: // private
nit: not necessary.

[kjlubick, 2016-09-01 17:24:08]

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botpage/bot-page-data.html (right):

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:123: lastRequest
= setTimeout(function(){
On 2016/09/01 at 15:16:18, stephana wrote:
> IMO the Polymer async method is preferrable, i.e. 
> 
>  ... this.async(function() {
>  .... 
> 
> it avoids having to bind 'this' and is in sync with Polymer's redraw
cycles,etc.

I did not know about Polymer's async.  Thanks!

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:165: // locale
time.
On 2016/09/01 at 15:16:18, stephana wrote:
> This seems something that the Date object should provide.

The Date Object will only give me the TimeZoneOffset, not the name of the
timezone.  

> Shouldn't something like bot[time].toString() give you the same results you
would get from this call.

Yes.  However, this is done on a new Date so we only need to get the time zone
once.

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:213: var timeZone
= str.substring(str.indexOf("("))
On 2016/09/01 at 15:16:18, stephana wrote:
> Same as above. Instead of copying the code there should be a shared function
that returns a date object in the desired format.

Done.  Created formatDate();

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botpage/bot-page.html (right):

https://codereview.chromium.org/2291323002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page.html:341: // private
On 2016/09/01 at 15:16:18, stephana wrote:
> nit: not necessary.

Removed.

[kjlubick, 2016-09-02 15:30:20]

Joe and I talked offline about a few visual things.  Those are now implemented:

https://screenshot.googleplex.com/vh4OLeQsyti

[jcgregorio, 2016-09-02 15:50:24]

lgtm

[KevinL, 2016-09-02 17:04:53]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-09-02 17:04:53]

lgtm

[KevinL, 2016-09-02 17:04:56]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:05:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:08:52]

Description was changed from

==========
Introduce new bot-page UI

The bot page is relatively simple (compared to the dynamic tables and
query-able filters used by bot-list and task-list)

It shows the bot's dimensions and other pertinent data.  There are buttons
for doing some bot maintenance (e.g. deleting dead bots), but those don't
quite work yet - next CL should add it.

In the demo code, you can view test-bot-001, 002 and 003 to see a normal
bot, a quarantined bot and a dead bot respectively.

The state is currently just a pretty printed version of the state object
that comes with the bot.  Perhaps in the future, important data from there
(like devices) can be pulled out and shown more easily.

BUG=631047
==========

to

==========
Introduce new bot-page UI

The bot page is relatively simple (compared to the dynamic tables and
query-able filters used by bot-list and task-list)

It shows the bot's dimensions and other pertinent data.  There are buttons
for doing some bot maintenance (e.g. deleting dead bots), but those don't
quite work yet - next CL should add it.

In the demo code, you can view test-bot-001, 002 and 003 to see a normal
bot, a quarantined bot and a dead bot respectively.

The state is currently just a pretty printed version of the state object
that comes with the bot.  Perhaps in the future, important data from there
(like devices) can be pulled out and shown more easily.

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/0f81b3641969489e5475701bc488f85d08cf29b3
==========

[commit-bot: I haz the power, 2016-09-02 17:08:54]

Committed patchset #7 (id:120001) as
https://github.com/luci/luci-py/commit/0f81b3641969489e5475701bc488f85d08cf29b3