Add aliases to bot-page and refactor duplicated code

Add aliases to bot-page and refactor duplicated code

BUG=631047
R=jcgregorio@google.com, kjlubick@chromium.org, stephana@google.com

Committed: https://github.com/luci/luci-py/commit/df72d2f5e9889dc2a2bb7be31ec1f002a771f13b

[kjlubick, 2016-09-02 14:43:57]

Description was changed from

==========
Add aliases to bot-page and clean up elsewhere

BUG=631047
==========

to

==========
Add aliases to bot-page and refactor duplicated code

BUG=631047
==========

[kjlubick, 2016-09-02 14:45:36]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-09-02 14:45:36]

New in bot-page
https://screenshot.googleplex.com/ESwVd1DyCUE

All other UI should be unchanged.

[jcgregorio, 2016-09-02 18:44:01]

https://codereview.chromium.org/2306103002/diff/20001/appengine/swarming/elem...
File appengine/swarming/elements/res/js/alias.js (right):

https://codereview.chromium.org/2306103002/diff/20001/appengine/swarming/elem...
appengine/swarming/elements/res/js/alias.js:1: // Copyright 2016 The LUCI
Authors. All rights reserved.
Add TODO to add unit tests for this code via Karma, or add them in this CL.

[jcgregorio, 2016-09-02 18:44:07]

lgtm

[KevinL, 2016-09-07 12:37:22]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-09-07 12:37:22]

lgtm

[stephana, 2016-09-07 12:46:15]

On 2016/09/02 18:44:07, jcgregorio wrote:
> lgtm

lgtm

[stephana, 2016-09-07 12:46:29]

https://codereview.chromium.org/2306103002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/js/alias.js (right):

https://codereview.chromium.org/2306103002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/js/alias.js:70: alias.apply = function(orig,
type) {
nit: 'apply' is the built in name to call a function in JS with 
an array of arguments. See

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

IMO it should be avoided as a function name, but it's not huge issue either.

[kjlubick, 2016-09-07 12:48:56]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-09-07 12:48:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/2306103002/#ps40001
(title: "Add TODO")

[commit-bot: I haz the power, 2016-09-07 12:49:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjlubick, 2016-09-07 12:50:19]

On 2016/09/07 at 12:46:29, stephana wrote:
>
https://codereview.chromium.org/2306103002/diff/40001/appengine/swarming/elem...
> File appengine/swarming/elements/res/js/alias.js (right):
> 
>
https://codereview.chromium.org/2306103002/diff/40001/appengine/swarming/elem...
> appengine/swarming/elements/res/js/alias.js:70: alias.apply = function(orig,
type) {
> nit: 'apply' is the built in name to call a function in JS with 
> an array of arguments. See
> 
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...
> 
> IMO it should be avoided as a function name, but it's not huge issue either.

Acknowledged.

[commit-bot: I haz the power, 2016-09-07 12:52:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 12:52:21]

Failed to apply patch for appengine/swarming/elements/build/js/js.js:
While running git apply --index -3 -p1;
  error: patch failed: appengine/swarming/elements/build/js/js.js:1
  Falling back to three-way merge...
  Applied patch to 'appengine/swarming/elements/build/js/js.js' with conflicts.
  U appengine/swarming/elements/build/js/js.js

Patch:       appengine/swarming/elements/build/js/js.js
Index: appengine/swarming/elements/build/js/js.js
diff --git a/appengine/swarming/elements/build/js/js.js
b/appengine/swarming/elements/build/js/js.js
index
d162b65f181af7c8507af29cec34ce28ca507af8..91fd591ee9d58da470e31b3929bcd20308a5d2cc
100644
--- a/appengine/swarming/elements/build/js/js.js
+++ b/appengine/swarming/elements/build/js/js.js
@@ -1,2 +1,2 @@
 !function(){window.WebComponents=window.WebComponents||{flags:{}};var
e="webcomponents-lite.js",t=document.querySelector('script[src*="'+e+'"]'),n={};if(!n.noOpts){if(location.search.slice(1).split("&").forEach(function(e){var
t,o=e.split("=");o[0]&&(t=o[0].match(/wc-(.+)/))&&(n[t[1]]=o[1]||!0)}),t)for(var
o,r=0;o=t.attributes[r];r++)"src"!==o.name&&(n[o.name]=o.value||!0);if(n.log&&n.log.split){var
i=n.log.split(",");n.log={},i.forEach(function(e){n.log[e]=!0})}else
n.log={}}n.register&&(window.CustomElements=window.CustomElements||{flags:{}},window.CustomElements.flags.register=n.register),WebComponents.flags=n}(),function(e){"use
strict";function t(e){return void 0!==h[e]}function
n(){s.call(this),this._isInvalid=!0}function
o(e){return""==e&&n.call(this),e.toLowerCase()}function r(e){var
t=e.charCodeAt(0);return
t>32&&127>t&&-1==[34,35,60,62,63,96].indexOf(t)?e:encodeURIComponent(e)}function
i(e){var t=e.charCodeAt(0);return
t>32&&127>t&&-1==[34,35,60,62,96].indexOf(t)?e:encodeURIComponent(e)}function
a(e,a,s){function c(e){g.push(e)}var d=a||"scheme
start",l=0,u="",w=!1,_=!1,g=[];e:for(;(e[l-1]!=p||0==l)&&!this._isInvalid;){var
b=e[l];switch(d){case"scheme start":if(!b||!m.test(b)){if(a){c("Invalid
scheme.");break e}u="",d="no
scheme";continue}u+=b.toLowerCase(),d="scheme";break;case"scheme":if(b&&v.test(b))u+=b.toLowerCase();else{if(":"!=b){if(a){if(p==b)break
e;c("Code point not allowed in scheme: "+b);break e}u="",l=0,d="no
scheme";continue}if(this._scheme=u,u="",a)break
e;t(this._scheme)&&(this._isRelative=!0),d="file"==this._scheme?"relative":this._isRelative&&s&&s._scheme==this._scheme?"relative
or authority":this._isRelative?"authority first slash":"scheme
data"}break;case"scheme
data":"?"==b?(this._query="?",d="query"):"#"==b?(this._fragment="#",d="fragment"):p!=b&&"\t"!=b&&"\n"!=b&&"\r"!=b&&(this._schemeData+=r(b));break;case"no
scheme":if(s&&t(s._scheme)){d="relative";continue}c("Missing
scheme."),n.call(this);break;case"relative or
authority":if("/"!=b||"/"!=e[l+1]){c("Expected /, got:
"+b),d="relative";continue}d="authority ignore
slashes";break;case"relative":if(this._isRelative=!0,"file"!=this._scheme&&(this._scheme=s._scheme),p==b){this._host=s._host,this._port=s._port,this._path=s._path.slice(),this._query=s._query,this._username=s._username,this._password=s._password;break
e}if("/"==b||"\\"==b)"\\"==b&&c("\\ is an invalid code point."),d="relative
slash";else
if("?"==b)this._host=s._host,this._port=s._port,this._path=s._path.slice(),this._query="?",this._username=s._username,this._password=s._password,d="query";else{if("#"!=b){var
y=e[l+1],E=e[l+2];("file"!=this._scheme||!m.test(b)||":"!=y&&"|"!=y||p!=E&&"/"!=E&&"\\"!=E&&"?"!=E&&"#"!=E)&&(this._host=s._host,this._port=s._port,this._username=s._username,this._password=s._password,this._path=s._path.slice(),this._path.pop()),d="relative
path";continue}this._host=s._host,this._port=s._port,this._path=s._path.slice(),this._query=s._query,this._fragment="#",this._username=s._username,this._password=s._password,d="fragment"}break;case"relative
slash":if("/"!=b&&"\\"!=b){"file"!=this._scheme&&(this._host=s._host,this._port=s._port,this._username=s._username,this._password=s._password),d="relative
path";continue}"\\"==b&&c("\\ is an invalid code
point."),d="file"==this._scheme?"file host":"authority ignore
slashes";break;case"authority first slash":if("/"!=b){c("Expected '/', got:
"+b),d="authority ignore slashes";continue}d="authority second
slash";break;case"authority second slash":if(d="authority ignore
slashes","/"!=b){c("Expected '/', got: "+b);continue}break;case"authority ignore
slashes":if("/"!=b&&"\\"!=b){d="authority";continue}c("Expected authority, got:
"+b);break;case"authority":if("@"==b){w&&(c("@ already
seen."),u+="%40"),w=!0;for(var L=0;L<u.length;L++){var
N=u[L];if("\t"!=N&&"\n"!=N&&"\r"!=N)if(":"!=N||null!==this._password){var
M=r(N);null!==this._password?this._password+=M:this._username+=M}else
this._password="";else c("Invalid whitespace in
authority.")}u=""}else{if(p==b||"/"==b||"\\"==b||"?"==b||"#"==b){l-=u.length,u="",d="host";continue}u+=b}break;case"file
host":if(p==b||"/"==b||"\\"==b||"?"==b||"#"==b){2!=u.length||!m.test(u[0])||":"!=u[1]&&"|"!=u[1]?0==u.length?d="relative
path start":(this._host=o.call(this,u),u="",d="relative path start"):d="relative
path";continue}"\t"==b||"\n"==b||"\r"==b?c("Invalid whitespace in file
host."):u+=b;break;case"host":case"hostname":if(":"!=b||_){if(p==b||"/"==b||"\\"==b||"?"==b||"#"==b){if(this._host=o.call(this,u),u="",d="relative
path start",a)break
e;continue}"\t"!=b&&"\n"!=b&&"\r"!=b?("["==b?_=!0:"]"==b&&(_=!1),u+=b):c("Invalid
code point in host/hostname: "+b)}else
if(this._host=o.call(this,u),u="",d="port","hostname"==a)break
e;break;case"port":if(/[0-9]/.test(b))u+=b;else{if(p==b||"/"==b||"\\"==b||"?"==b||"#"==b||a){if(""!=u){var
T=parseInt(u,10);T!=h[this._scheme]&&(this._port=T+""),u=""}if(a)break
e;d="relative path start";continue}"\t"==b||"\n"==b||"\r"==b?c("Invalid code
point in port: "+b):n.call(this)}break;case"relative path
start":if("\\"==b&&c("'\\' not allowed in path."),d="relative
path","/"!=b&&"\\"!=b)continue;break;case"relative
path":if(p!=b&&"/"!=b&&"\\"!=b&&(a||"?"!=b&&"#"!=b))"\t"!=b&&"\n"!=b&&"\r"!=b&&(u+=r(b));else{"\\"==b&&c("\\
not allowed in relative path.");var
O;(O=f[u.toLowerCase()])&&(u=O),".."==u?(this._path.pop(),"/"!=b&&"\\"!=b&&this._path.push("")):"."==u&&"/"!=b&&"\\"!=b?this._path.push(""):"."!=u&&("file"==this._scheme&&0==this._path.length&&2==u.length&&m.test(u[0])&&"|"==u[1]&&(u=u[0]+":"),this._path.push(u)),u="","?"==b?(this._query="?",d="query"):"#"==b&&(this._fragment="#",d="fragment")}break;case"query":a||"#"!=b?p!=b&&"\t"!=b&&"\n"!=b&&"\r"!=b&&(this._query+=i(b)):(this._fragment="#",d="fragment");break;case"fragment":p!=b&&"\t"!=b&&"\n"!=b&&"\r"!=b&&(this._fragment+=b)}l++}}function
s(){this._scheme="",this._schemeData="",this._username="",this._password=null,this._host="",this._port="",this._path=[],this._query="",this._fragment="",this._isInvalid=!1,this._isRelative=!1}function
c(e,t){void 0===t||t instanceof c||(t=new
c(String(t))),this._url=e,s.call(this);var n=e.replace(/^[ \t\r\n\f]+|[
\t\r\n\f]+$/g,"");a.call(this,n,null,t)}var d=!1;if(!e.forceJURL)try{var l=new
URL("b","http://a");l.pathname="c%20d",d="http://a/c%20d"===l.href}catch(u){}if(!d){var
h=Object.create(null);h.ftp=21,h.file=0,h.gopher=70,h.http=80,h.https=443,h.ws=80,h.wss=443;var
f=Object.create(null);f["%2e"]=".",f[".%2e"]="..",f["%2e."]="..",f["%2e%2e"]="..";var
p=void
0,m=/[a-zA-Z]/,v=/[a-zA-Z0-9\+\-\.]/;c.prototype={toString:function(){return
this.href},get href(){if(this._isInvalid)return this._url;var
e="";return""==this._username&&null==this._password||(e=this._username+(null!=this._password?":"+this._password:"")+"@"),this.protocol+(this._isRelative?"//"+e+this.host:"")+this.pathname+this._query+this._fragment},set
href(e){s.call(this),a.call(this,e)},get protocol(){return this._scheme+":"},set
protocol(e){this._isInvalid||a.call(this,e+":","scheme start")},get
host(){return
this._isInvalid?"":this._port?this._host+":"+this._port:this._host},set
host(e){!this._isInvalid&&this._isRelative&&a.call(this,e,"host")},get
hostname(){return this._host},set
hostname(e){!this._isInvalid&&this._isRelative&&a.call(this,e,"hostname")},get
port(){return this._port},set
port(e){!this._isInvalid&&this._isRelative&&a.call(this,e,"port")},get
pathname(){return
this._isInvalid?"":this._isRelative?"/"+this._path.join("/"):this._schemeData},set
pathname(e){!this._isInvalid&&this._isRelative&&(this._path=[],a.call(this,e,"relative
path start"))},get search(){return
this._isInvalid||!this._query||"?"==this._query?"":this._query},set
search(e){!this._isInvalid&&this._isRelative&&(this._query="?","?"==e[0]&&(e=e.slice(1)),a.call(this,e,"query"))},get
hash(){return
this._isInvalid||!this._fragment||"#"==this._fragment?"":this._fragment},set
hash(e){this._isInvalid||(this._fragment="#","#"==e[0]&&(e=e.slice(1)),a.call(this,e,"fragment"))},get
origin(){var
e;if(this._isInvalid||!this._scheme)return"";switch(this._scheme){case"data":case"file":case"javascript":case"mailto":return"null"}return
e=this.host,e?this._scheme+"://"+e:""}};var
w=e.URL;w&&(c.createObjectURL=function(e){return
w.createObjectURL.apply(w,arguments)},c.revokeObjectURL=function(e){w.revokeObjectURL(e)}),e.URL=c}}(self),"undefined"==typeof
WeakMap&&!function(){var
e=Object.defineProperty,t=Date.now()%1e9,n=function(){this.name="__st"+(1e9*Math.random()>>>0)+(t++
+"__")};n.prototype={set:function(t,n){var o=t[this.name];return
o&&o[0]===t?o[1]=n:e(t,this.name,{value:[t,n],writable:!0}),this},get:function(e){var
t;return(t=e[this.name])&&t[0]===e?t[1]:void 0},delete:function(e){var
t=e[this.name];return t&&t[0]===e?(t[0]=t[1]=void 0,!0):!1},has:function(e){var
t=e[this.name];return t?t[0]===e:!1}},window.WeakMap=n}(),function(e){function
t(e){b.push(e),g||(g=!0,m(o))}function n(e){return
window.ShadowDOMPolyfill&&window.ShadowDOMPolyfill.wrapIfNeeded(e)||e}function
o(){g=!1;var e=b;b=[],e.sort(function(e,t){return e.uid_-t.uid_});var
t=!1;e.forEach(function(e){var
n=e.takeRecords();r(e),n.length&&(e.callback_(n,e),t=!0)}),t&&o()}function
r(e){e.nodes_.forEa…
(message too large)

[kjlubick, 2016-09-07 12:57:47]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-09-07 12:57:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjlubick@chromium.org, jcgregorio@google.com, stephana@google.com
Link to the patchset: https://codereview.chromium.org/2306103002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-07 12:57:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 13:00:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 13:00:43]

Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/311d8b9062fd8810)

[kjlubick, 2016-09-07 13:05:22]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-09-07 13:05:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjlubick@chromium.org, jcgregorio@google.com, stephana@google.com
Link to the patchset: https://codereview.chromium.org/2306103002/#ps80001
(title: "rebase again")

[commit-bot: I haz the power, 2016-09-07 13:05:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 13:08:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 13:08:51]

Failed to apply patch for appengine/swarming/elements/build/js/js.js:
While running git apply --index -3 -p1;
  error: patch failed: appengine/swarming/elements/build/js/js.js:1
  Falling back to three-way merge...
  Applied patch to 'appengine/swarming/elements/build/js/js.js' with conflicts.
  U appengine/swarming/elements/build/js/js.js

Patch:       appengine/swarming/elements/build/js/js.js
Index: appengine/swarming/elements/build/js/js.js
diff --git a/appengine/swarming/elements/build/js/js.js
b/appengine/swarming/elements/build/js/js.js
index
d162b65f181af7c8507af29cec34ce28ca507af8..069a9a1287f29de86e47cd99384e7102640959b3
100644
--- a/appengine/swarming/elements/build/js/js.js
+++ b/appengine/swarming/elements/build/js/js.js
@@ -1,2 +1,2 @@
 !function(){window.WebComponents=window.WebComponents||{flags:{}};var
e="webcomponents-lite.js",t=document.querySelector('script[src*="'+e+'"]'),n={};if(!n.noOpts){if(location.search.slice(1).split("&").forEach(function(e){var
t,o=e.split("=");o[0]&&(t=o[0].match(/wc-(.+)/))&&(n[t[1]]=o[1]||!0)}),t)for(var
o,r=0;o=t.attributes[r];r++)"src"!==o.name&&(n[o.name]=o.value||!0);if(n.log&&n.log.split){var
i=n.log.split(",");n.log={},i.forEach(function(e){n.log[e]=!0})}else
n.log={}}n.register&&(window.CustomElements=window.CustomElements||{flags:{}},window.CustomElements.flags.register=n.register),WebComponents.flags=n}(),function(e){"use
strict";function t(e){return void 0!==h[e]}function
n(){s.call(this),this._isInvalid=!0}function
o(e){return""==e&&n.call(this),e.toLowerCase()}function r(e){var
t=e.charCodeAt(0);return
t>32&&127>t&&-1==[34,35,60,62,63,96].indexOf(t)?e:encodeURIComponent(e)}function
i(e){var t=e.charCodeAt(0);return
t>32&&127>t&&-1==[34,35,60,62,96].indexOf(t)?e:encodeURIComponent(e)}function
a(e,a,s){function c(e){g.push(e)}var d=a||"scheme
start",l=0,u="",w=!1,_=!1,g=[];e:for(;(e[l-1]!=p||0==l)&&!this._isInvalid;){var
b=e[l];switch(d){case"scheme start":if(!b||!m.test(b)){if(a){c("Invalid
scheme.");break e}u="",d="no
scheme";continue}u+=b.toLowerCase(),d="scheme";break;case"scheme":if(b&&v.test(b))u+=b.toLowerCase();else{if(":"!=b){if(a){if(p==b)break
e;c("Code point not allowed in scheme: "+b);break e}u="",l=0,d="no
scheme";continue}if(this._scheme=u,u="",a)break
e;t(this._scheme)&&(this._isRelative=!0),d="file"==this._scheme?"relative":this._isRelative&&s&&s._scheme==this._scheme?"relative
or authority":this._isRelative?"authority first slash":"scheme
data"}break;case"scheme
data":"?"==b?(this._query="?",d="query"):"#"==b?(this._fragment="#",d="fragment"):p!=b&&"\t"!=b&&"\n"!=b&&"\r"!=b&&(this._schemeData+=r(b));break;case"no
scheme":if(s&&t(s._scheme)){d="relative";continue}c("Missing
scheme."),n.call(this);break;case"relative or
authority":if("/"!=b||"/"!=e[l+1]){c("Expected /, got:
"+b),d="relative";continue}d="authority ignore
slashes";break;case"relative":if(this._isRelative=!0,"file"!=this._scheme&&(this._scheme=s._scheme),p==b){this._host=s._host,this._port=s._port,this._path=s._path.slice(),this._query=s._query,this._username=s._username,this._password=s._password;break
e}if("/"==b||"\\"==b)"\\"==b&&c("\\ is an invalid code point."),d="relative
slash";else
if("?"==b)this._host=s._host,this._port=s._port,this._path=s._path.slice(),this._query="?",this._username=s._username,this._password=s._password,d="query";else{if("#"!=b){var
y=e[l+1],E=e[l+2];("file"!=this._scheme||!m.test(b)||":"!=y&&"|"!=y||p!=E&&"/"!=E&&"\\"!=E&&"?"!=E&&"#"!=E)&&(this._host=s._host,this._port=s._port,this._username=s._username,this._password=s._password,this._path=s._path.slice(),this._path.pop()),d="relative
path";continue}this._host=s._host,this._port=s._port,this._path=s._path.slice(),this._query=s._query,this._fragment="#",this._username=s._username,this._password=s._password,d="fragment"}break;case"relative
slash":if("/"!=b&&"\\"!=b){"file"!=this._scheme&&(this._host=s._host,this._port=s._port,this._username=s._username,this._password=s._password),d="relative
path";continue}"\\"==b&&c("\\ is an invalid code
point."),d="file"==this._scheme?"file host":"authority ignore
slashes";break;case"authority first slash":if("/"!=b){c("Expected '/', got:
"+b),d="authority ignore slashes";continue}d="authority second
slash";break;case"authority second slash":if(d="authority ignore
slashes","/"!=b){c("Expected '/', got: "+b);continue}break;case"authority ignore
slashes":if("/"!=b&&"\\"!=b){d="authority";continue}c("Expected authority, got:
"+b);break;case"authority":if("@"==b){w&&(c("@ already
seen."),u+="%40"),w=!0;for(var L=0;L<u.length;L++){var
N=u[L];if("\t"!=N&&"\n"!=N&&"\r"!=N)if(":"!=N||null!==this._password){var
M=r(N);null!==this._password?this._password+=M:this._username+=M}else
this._password="";else c("Invalid whitespace in
authority.")}u=""}else{if(p==b||"/"==b||"\\"==b||"?"==b||"#"==b){l-=u.length,u="",d="host";continue}u+=b}break;case"file
host":if(p==b||"/"==b||"\\"==b||"?"==b||"#"==b){2!=u.length||!m.test(u[0])||":"!=u[1]&&"|"!=u[1]?0==u.length?d="relative
path start":(this._host=o.call(this,u),u="",d="relative path start"):d="relative
path";continue}"\t"==b||"\n"==b||"\r"==b?c("Invalid whitespace in file
host."):u+=b;break;case"host":case"hostname":if(":"!=b||_){if(p==b||"/"==b||"\\"==b||"?"==b||"#"==b){if(this._host=o.call(this,u),u="",d="relative
path start",a)break
e;continue}"\t"!=b&&"\n"!=b&&"\r"!=b?("["==b?_=!0:"]"==b&&(_=!1),u+=b):c("Invalid
code point in host/hostname: "+b)}else
if(this._host=o.call(this,u),u="",d="port","hostname"==a)break
e;break;case"port":if(/[0-9]/.test(b))u+=b;else{if(p==b||"/"==b||"\\"==b||"?"==b||"#"==b||a){if(""!=u){var
T=parseInt(u,10);T!=h[this._scheme]&&(this._port=T+""),u=""}if(a)break
e;d="relative path start";continue}"\t"==b||"\n"==b||"\r"==b?c("Invalid code
point in port: "+b):n.call(this)}break;case"relative path
start":if("\\"==b&&c("'\\' not allowed in path."),d="relative
path","/"!=b&&"\\"!=b)continue;break;case"relative
path":if(p!=b&&"/"!=b&&"\\"!=b&&(a||"?"!=b&&"#"!=b))"\t"!=b&&"\n"!=b&&"\r"!=b&&(u+=r(b));else{"\\"==b&&c("\\
not allowed in relative path.");var
O;(O=f[u.toLowerCase()])&&(u=O),".."==u?(this._path.pop(),"/"!=b&&"\\"!=b&&this._path.push("")):"."==u&&"/"!=b&&"\\"!=b?this._path.push(""):"."!=u&&("file"==this._scheme&&0==this._path.length&&2==u.length&&m.test(u[0])&&"|"==u[1]&&(u=u[0]+":"),this._path.push(u)),u="","?"==b?(this._query="?",d="query"):"#"==b&&(this._fragment="#",d="fragment")}break;case"query":a||"#"!=b?p!=b&&"\t"!=b&&"\n"!=b&&"\r"!=b&&(this._query+=i(b)):(this._fragment="#",d="fragment");break;case"fragment":p!=b&&"\t"!=b&&"\n"!=b&&"\r"!=b&&(this._fragment+=b)}l++}}function
s(){this._scheme="",this._schemeData="",this._username="",this._password=null,this._host="",this._port="",this._path=[],this._query="",this._fragment="",this._isInvalid=!1,this._isRelative=!1}function
c(e,t){void 0===t||t instanceof c||(t=new
c(String(t))),this._url=e,s.call(this);var n=e.replace(/^[ \t\r\n\f]+|[
\t\r\n\f]+$/g,"");a.call(this,n,null,t)}var d=!1;if(!e.forceJURL)try{var l=new
URL("b","http://a");l.pathname="c%20d",d="http://a/c%20d"===l.href}catch(u){}if(!d){var
h=Object.create(null);h.ftp=21,h.file=0,h.gopher=70,h.http=80,h.https=443,h.ws=80,h.wss=443;var
f=Object.create(null);f["%2e"]=".",f[".%2e"]="..",f["%2e."]="..",f["%2e%2e"]="..";var
p=void
0,m=/[a-zA-Z]/,v=/[a-zA-Z0-9\+\-\.]/;c.prototype={toString:function(){return
this.href},get href(){if(this._isInvalid)return this._url;var
e="";return""==this._username&&null==this._password||(e=this._username+(null!=this._password?":"+this._password:"")+"@"),this.protocol+(this._isRelative?"//"+e+this.host:"")+this.pathname+this._query+this._fragment},set
href(e){s.call(this),a.call(this,e)},get protocol(){return this._scheme+":"},set
protocol(e){this._isInvalid||a.call(this,e+":","scheme start")},get
host(){return
this._isInvalid?"":this._port?this._host+":"+this._port:this._host},set
host(e){!this._isInvalid&&this._isRelative&&a.call(this,e,"host")},get
hostname(){return this._host},set
hostname(e){!this._isInvalid&&this._isRelative&&a.call(this,e,"hostname")},get
port(){return this._port},set
port(e){!this._isInvalid&&this._isRelative&&a.call(this,e,"port")},get
pathname(){return
this._isInvalid?"":this._isRelative?"/"+this._path.join("/"):this._schemeData},set
pathname(e){!this._isInvalid&&this._isRelative&&(this._path=[],a.call(this,e,"relative
path start"))},get search(){return
this._isInvalid||!this._query||"?"==this._query?"":this._query},set
search(e){!this._isInvalid&&this._isRelative&&(this._query="?","?"==e[0]&&(e=e.slice(1)),a.call(this,e,"query"))},get
hash(){return
this._isInvalid||!this._fragment||"#"==this._fragment?"":this._fragment},set
hash(e){this._isInvalid||(this._fragment="#","#"==e[0]&&(e=e.slice(1)),a.call(this,e,"fragment"))},get
origin(){var
e;if(this._isInvalid||!this._scheme)return"";switch(this._scheme){case"data":case"file":case"javascript":case"mailto":return"null"}return
e=this.host,e?this._scheme+"://"+e:""}};var
w=e.URL;w&&(c.createObjectURL=function(e){return
w.createObjectURL.apply(w,arguments)},c.revokeObjectURL=function(e){w.revokeObjectURL(e)}),e.URL=c}}(self),"undefined"==typeof
WeakMap&&!function(){var
e=Object.defineProperty,t=Date.now()%1e9,n=function(){this.name="__st"+(1e9*Math.random()>>>0)+(t++
+"__")};n.prototype={set:function(t,n){var o=t[this.name];return
o&&o[0]===t?o[1]=n:e(t,this.name,{value:[t,n],writable:!0}),this},get:function(e){var
t;return(t=e[this.name])&&t[0]===e?t[1]:void 0},delete:function(e){var
t=e[this.name];return t&&t[0]===e?(t[0]=t[1]=void 0,!0):!1},has:function(e){var
t=e[this.name];return t?t[0]===e:!1}},window.WeakMap=n}(),function(e){function
t(e){b.push(e),g||(g=!0,m(o))}function n(e){return
window.ShadowDOMPolyfill&&window.ShadowDOMPolyfill.wrapIfNeeded(e)||e}function
o(){g=!1;var e=b;b=[],e.sort(function(e,t){return e.uid_-t.uid_});var
t=!1;e.forEach(function(e){var
n=e.takeRecords();r(e),n.length&&(e.callback_(n,e),t=!0)}),t&&o()}function
r(e){e.nodes_.forEa…
(message too large)

[kjlubick, 2016-09-07 15:28:09]

Description was changed from

==========
Add aliases to bot-page and refactor duplicated code

BUG=631047
==========

to

==========
Add aliases to bot-page and refactor duplicated code

BUG=631047
R=jcgregorio@google.com, kjlubick@chromium.org, stephana@google.com

Committed:
https://github.com/luci/luci-py/commit/df72d2f5e9889dc2a2bb7be31ec1f002a771f13b
==========

[kjlubick, 2016-09-07 15:28:10]

Committed patchset #5 (id:80001) manually as
df72d2f5e9889dc2a2bb7be31ec1f002a771f13b (presubmit successful).