Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2301453002: Quic use reduced PING timeout when previous connection times out with open streams (Closed)
Patch Set: address rch's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator.cc
diff --git a/components/network_session_configurator/network_session_configurator.cc b/components/network_session_configurator/network_session_configurator.cc
index 772fd2fd1b8062bba954da430ed7cd70c6f26f1c..10b00fc314f02f90d75f3c96ca94ff03e9e48fde 100644
--- a/components/network_session_configurator/network_session_configurator.cc
+++ b/components/network_session_configurator/network_session_configurator.cc
@@ -207,6 +207,17 @@ int GetQuicIdleConnectionTimeoutSeconds(
return 0;
}
+int GetQuicReducedPingTimeoutSeconds(
+ const VariationParameters& quic_trial_params) {
+ int value;
+ if (base::StringToInt(
+ GetVariationParam(quic_trial_params, "reduced_ping_timeout_seconds"),
+ &value)) {
+ return value;
+ }
+ return 0;
+}
+
int GetQuicPacketReaderYieldAfterDurationMilliseconds(
const VariationParameters& quic_trial_params) {
int value;
@@ -340,6 +351,12 @@ void ConfigureQuicParams(base::StringPiece quic_trial_group,
params->quic_idle_connection_timeout_seconds =
idle_connection_timeout_seconds;
}
+ int reduced_ping_timeout_seconds =
+ GetQuicReducedPingTimeoutSeconds(quic_trial_params);
+ if (reduced_ping_timeout_seconds > 0 &&
+ reduced_ping_timeout_seconds < net::kPingTimeoutSecs) {
+ params->quic_reduced_ping_timeout_seconds = reduced_ping_timeout_seconds;
+ }
int packet_reader_yield_after_duration_milliseconds =
GetQuicPacketReaderYieldAfterDurationMilliseconds(quic_trial_params);
if (packet_reader_yield_after_duration_milliseconds != 0) {

Powered by Google App Engine
This is Rietveld 408576698