Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2301453002: Quic use reduced PING timeout when previous connection times out with open streams (Closed)
Patch Set: address rch's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index c749fa87033245e44e8e67a860bf20f23b09700b..b4b03c190e710401343413e28aa62e0a51b39ac0 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -80,6 +80,7 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
EXPECT_FALSE(params_.quic_close_sessions_on_ip_change);
EXPECT_EQ(net::kIdleConnectionTimeoutSeconds,
params_.quic_idle_connection_timeout_seconds);
+ EXPECT_EQ(net::kPingTimeoutSecs, params_.quic_reduced_ping_timeout_seconds);
EXPECT_EQ(net::kQuicYieldAfterDurationMilliseconds,
params_.quic_packet_reader_yield_after_duration_milliseconds);
EXPECT_FALSE(params_.quic_race_cert_verification);
@@ -142,6 +143,36 @@ TEST_F(NetworkSessionConfiguratorTest,
}
TEST_F(NetworkSessionConfiguratorTest,
+ NegativeQuicReducedPingTimeoutSecondsFieldTrialParams) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["reduced_ping_timeout_seconds"] = "-5";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+ ParseFieldTrials();
+ EXPECT_EQ(net::kPingTimeoutSecs, params_.quic_reduced_ping_timeout_seconds);
+}
+
+TEST_F(NetworkSessionConfiguratorTest,
+ LargeQuicReducedPingTimeoutSecondsFieldTrialParams) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["reduced_ping_timeout_seconds"] = "50";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+ ParseFieldTrials();
+ EXPECT_EQ(net::kPingTimeoutSecs, params_.quic_reduced_ping_timeout_seconds);
+}
+
+TEST_F(NetworkSessionConfiguratorTest,
+ QuicReducedPingTimeoutSecondsFieldTrialParams) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["reduced_ping_timeout_seconds"] = "10";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+ ParseFieldTrials();
+ EXPECT_EQ(10, params_.quic_reduced_ping_timeout_seconds);
+}
+
+TEST_F(NetworkSessionConfiguratorTest,
QuicPacketReaderYieldAfterDurationMillisecondsFieldTrialParams) {
std::map<std::string, std::string> field_trial_params;
field_trial_params["packet_reader_yield_after_duration_milliseconds"] = "10";

Powered by Google App Engine
This is Rietveld 408576698