Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2301453002: Quic use reduced PING timeout when previous connection times out with open streams (Closed)
Patch Set: address rch's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/network_session_configurator/network_session_configurator.h " 5 #include "components/network_session_configurator/network_session_configurator.h "
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "base/metrics/field_trial.h" 9 #include "base/metrics/field_trial.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 const VariationParameters& quic_trial_params) { 200 const VariationParameters& quic_trial_params) {
201 int value; 201 int value;
202 if (base::StringToInt(GetVariationParam(quic_trial_params, 202 if (base::StringToInt(GetVariationParam(quic_trial_params,
203 "idle_connection_timeout_seconds"), 203 "idle_connection_timeout_seconds"),
204 &value)) { 204 &value)) {
205 return value; 205 return value;
206 } 206 }
207 return 0; 207 return 0;
208 } 208 }
209 209
210 int GetQuicReducedPingTimeoutSeconds(
211 const VariationParameters& quic_trial_params) {
212 int value;
213 if (base::StringToInt(
214 GetVariationParam(quic_trial_params, "reduced_ping_timeout_seconds"),
215 &value)) {
216 return value;
217 }
218 return 0;
219 }
220
210 int GetQuicPacketReaderYieldAfterDurationMilliseconds( 221 int GetQuicPacketReaderYieldAfterDurationMilliseconds(
211 const VariationParameters& quic_trial_params) { 222 const VariationParameters& quic_trial_params) {
212 int value; 223 int value;
213 if (base::StringToInt( 224 if (base::StringToInt(
214 GetVariationParam(quic_trial_params, 225 GetVariationParam(quic_trial_params,
215 "packet_reader_yield_after_duration_milliseconds"), 226 "packet_reader_yield_after_duration_milliseconds"),
216 &value)) { 227 &value)) {
217 return value; 228 return value;
218 } 229 }
219 return 0; 230 return 0;
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 params->quic_connection_options = 344 params->quic_connection_options =
334 GetQuicConnectionOptions(quic_trial_params); 345 GetQuicConnectionOptions(quic_trial_params);
335 params->quic_close_sessions_on_ip_change = 346 params->quic_close_sessions_on_ip_change =
336 ShouldQuicCloseSessionsOnIpChange(quic_trial_params); 347 ShouldQuicCloseSessionsOnIpChange(quic_trial_params);
337 int idle_connection_timeout_seconds = 348 int idle_connection_timeout_seconds =
338 GetQuicIdleConnectionTimeoutSeconds(quic_trial_params); 349 GetQuicIdleConnectionTimeoutSeconds(quic_trial_params);
339 if (idle_connection_timeout_seconds != 0) { 350 if (idle_connection_timeout_seconds != 0) {
340 params->quic_idle_connection_timeout_seconds = 351 params->quic_idle_connection_timeout_seconds =
341 idle_connection_timeout_seconds; 352 idle_connection_timeout_seconds;
342 } 353 }
354 int reduced_ping_timeout_seconds =
355 GetQuicReducedPingTimeoutSeconds(quic_trial_params);
356 if (reduced_ping_timeout_seconds > 0 &&
357 reduced_ping_timeout_seconds < net::kPingTimeoutSecs) {
358 params->quic_reduced_ping_timeout_seconds = reduced_ping_timeout_seconds;
359 }
343 int packet_reader_yield_after_duration_milliseconds = 360 int packet_reader_yield_after_duration_milliseconds =
344 GetQuicPacketReaderYieldAfterDurationMilliseconds(quic_trial_params); 361 GetQuicPacketReaderYieldAfterDurationMilliseconds(quic_trial_params);
345 if (packet_reader_yield_after_duration_milliseconds != 0) { 362 if (packet_reader_yield_after_duration_milliseconds != 0) {
346 params->quic_packet_reader_yield_after_duration_milliseconds = 363 params->quic_packet_reader_yield_after_duration_milliseconds =
347 packet_reader_yield_after_duration_milliseconds; 364 packet_reader_yield_after_duration_milliseconds;
348 } 365 }
349 params->quic_race_cert_verification = 366 params->quic_race_cert_verification =
350 ShouldQuicRaceCertVerification(quic_trial_params); 367 ShouldQuicRaceCertVerification(quic_trial_params);
351 params->quic_disable_preconnect_if_0rtt = 368 params->quic_disable_preconnect_if_0rtt =
352 ShouldQuicDisablePreConnectIfZeroRtt(quic_trial_params); 369 ShouldQuicDisablePreConnectIfZeroRtt(quic_trial_params);
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 std::string http2_trial_group = 423 std::string http2_trial_group =
407 base::FieldTrialList::FindFullName(kHttp2FieldTrialName); 424 base::FieldTrialList::FindFullName(kHttp2FieldTrialName);
408 ConfigureHttp2Params(http2_trial_group, params); 425 ConfigureHttp2Params(http2_trial_group, params);
409 426
410 const std::string tfo_trial_group = 427 const std::string tfo_trial_group =
411 base::FieldTrialList::FindFullName(kTCPFastOpenFieldTrialName); 428 base::FieldTrialList::FindFullName(kTCPFastOpenFieldTrialName);
412 ConfigureTCPFastOpenParams(tfo_trial_group, params); 429 ConfigureTCPFastOpenParams(tfo_trial_group, params);
413 } 430 }
414 431
415 } // namespace network_session_configurator 432 } // namespace network_session_configurator
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698