Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: net/http/http_network_session.cc

Issue 2301453002: Quic use reduced PING timeout when previous connection times out with open streams (Closed)
Patch Set: address rch's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_session.cc
diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc
index 5a36ab09483903c030b1b16361c3c6559529bc11..95b45badaf2062743b92a55376fa54d81e2fb859 100644
--- a/net/http/http_network_session.cc
+++ b/net/http/http_network_session.cc
@@ -122,6 +122,7 @@ HttpNetworkSession::Params::Params()
quic_threshold_timeouts_streams_open(0),
quic_close_sessions_on_ip_change(false),
quic_idle_connection_timeout_seconds(kIdleConnectionTimeoutSeconds),
+ quic_reduced_ping_timeout_seconds(kPingTimeoutSecs),
ianswett 2016/09/01 20:04:15 nit: kDefaultPingTimeoutSecs?
Zhongyi Shi 2016/09/02 00:48:21 Shall we change it when we decide to default this
quic_packet_reader_yield_after_duration_milliseconds(
kQuicYieldAfterDurationMilliseconds),
quic_disable_preconnect_if_0rtt(false),
@@ -187,6 +188,7 @@ HttpNetworkSession::HttpNetworkSession(const Params& params)
params.quic_close_sessions_on_ip_change,
params.disable_quic_on_timeout_with_open_streams,
params.quic_idle_connection_timeout_seconds,
+ params.quic_reduced_ping_timeout_seconds,
params.quic_packet_reader_yield_after_duration_milliseconds,
params.quic_migrate_sessions_on_network_change,
params.quic_migrate_sessions_early,
@@ -339,6 +341,8 @@ std::unique_ptr<base::Value> HttpNetworkSession::QuicInfoToValue() const {
params_.quic_max_server_configs_stored_in_properties);
dict->SetInteger("idle_connection_timeout_seconds",
params_.quic_idle_connection_timeout_seconds);
+ dict->SetInteger("reduced_ping_timeout_seconds",
+ params_.quic_reduced_ping_timeout_seconds);
dict->SetInteger(
"packet_reader_yield_after_duration_milliseconds",
params_.quic_packet_reader_yield_after_duration_milliseconds);

Powered by Google App Engine
This is Rietveld 408576698