Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 230083003: Oilpan: Move WorkerClients to the managed heap and trace its supplements. (Closed)

Created:
6 years, 8 months ago by zerny-chromium
Modified:
6 years, 8 months ago
CC:
blink-reviews, kinuko, tzik, serviceworker-reviews, jsbell+serviceworker_chromium.org, nhiroki, falken, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org, oilpan-reviews
Visibility:
Public.

Description

Oilpan: Move WorkerClients to the managed heap and trace its supplements. R=ager@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171243

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR comments and unbreak the non-oilpan build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -60 lines) Patch
M Source/core/clipboard/DataObject.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/clipboard/DataObject.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/frame/Navigator.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/frame/Screen.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorker.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerClients.h View 1 1 chunk +8 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerNavigator.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/workers/WorkerThreadStartupData.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/workers/WorkerThreadStartupData.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/modules/filesystem/LocalFileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerClient.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Supplementable.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/DatabaseClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WorkerGlobalScopeProxyProviderImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WorkerPermissionClient.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
zerny-chromium
6 years, 8 months ago (2014-04-09 08:27:17 UTC) #1
Mads Ager (chromium)
lgtm
6 years, 8 months ago (2014-04-09 08:45:48 UTC) #2
zerny-chromium
Kent, could you do the owners review?
6 years, 8 months ago (2014-04-09 08:46:54 UTC) #3
haraken
LGTM https://codereview.chromium.org/230083003/diff/1/Source/core/workers/WorkerClients.h File Source/core/workers/WorkerClients.h (right): https://codereview.chromium.org/230083003/diff/1/Source/core/workers/WorkerClients.h#newcode52 Source/core/workers/WorkerClients.h:52: virtual void trace(Visitor* visitor) Add OVERRIDE. https://codereview.chromium.org/230083003/diff/1/Source/core/workers/WorkerGlobalScope.cpp File ...
6 years, 8 months ago (2014-04-09 09:04:38 UTC) #4
zerny-chromium
Thanks for the reviews. The changes broke the non-oilpan build with plugin errors. I've pushed ...
6 years, 8 months ago (2014-04-09 09:31:46 UTC) #5
tkent
lgtm
6 years, 8 months ago (2014-04-10 06:01:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/230083003/20001
6 years, 8 months ago (2014-04-10 06:01:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 06:34:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-10 06:34:45 UTC) #9
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 8 months ago (2014-04-10 06:41:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/230083003/20001
6 years, 8 months ago (2014-04-10 06:41:05 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 07:16:36 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-10 07:16:36 UTC) #13
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 8 months ago (2014-04-10 07:52:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/230083003/20001
6 years, 8 months ago (2014-04-10 07:52:27 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 08:22:40 UTC) #16
Message was sent while issue was closed. 
Change committed as 171243

Powered by Google App Engine
This is Rietveld 408576698