Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 230083003: Oilpan: Move WorkerClients to the managed heap and trace its supplements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 230083003: Oilpan: Move WorkerClients to the managed heap and trace its supplements. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: CR comments and unbreak the non-oilpan build Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index d99db4b176956aff43a19cbbd90ef72d3ab67eaf..6a98438460b07b0a7bc37adb4ec9430bb397c03d 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -48,10 +48,7 @@ public:

virtual void didHandleFetchEvent(int fetchEventID, PassRefPtr<WebCore::Response>) OVERRIDE;

virtual void didHandleSyncEvent(int syncEventID) OVERRIDE;

- virtual void trace(WebCore::Visitor*) OVERRIDE

- {

- // FIXME: Oilpan: Move WorkerClients to the managed heap before using this trace method.

- }

+ virtual void trace(WebCore::Visitor*) OVERRIDE { }

private:

ServiceWorkerGlobalScopeClientImpl(PassOwnPtr<WebServiceWorkerContextClient>);

« no previous file with comments | « Source/web/DatabaseClientImpl.h ('k') | Source/web/WebEmbeddedWorkerImpl.cpp » ('j') | no next file with comments »