Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 230083003: Oilpan: Move WorkerClients to the managed heap and trace its supplements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 230083003: Oilpan: Move WorkerClients to the managed heap and trace its supplements. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: CR comments and unbreak the non-oilpan build Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/web/DatabaseClientImpl.h ('k') | Source/web/WebEmbeddedWorkerImpl.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2014 Google Inc. All rights reserved.	2 * Copyright (C) 2014 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 30 matching lines...) Expand all Loading...
41 class ServiceWorkerGlobalScopeClientImpl FINAL : public WebCore::ServiceWorkerGl obalScopeClient {	41 class ServiceWorkerGlobalScopeClientImpl FINAL : public WebCore::ServiceWorkerGl obalScopeClient {

42 public:	42 public:

43 static PassOwnPtr<WebCore::ServiceWorkerGlobalScopeClient> create(PassOwnPtr <WebServiceWorkerContextClient>);	43 static PassOwnPtr<WebCore::ServiceWorkerGlobalScopeClient> create(PassOwnPtr <WebServiceWorkerContextClient>);

44 virtual ~ServiceWorkerGlobalScopeClientImpl();	44 virtual ~ServiceWorkerGlobalScopeClientImpl();

45	45

46 virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult ) OVERRIDE;	46 virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult ) OVERRIDE;

47 virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEvent Result) OVERRIDE;	47 virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEvent Result) OVERRIDE;

48 virtual void didHandleFetchEvent(int fetchEventID, PassRefPtr<WebCore::Respo nse>) OVERRIDE;	48 virtual void didHandleFetchEvent(int fetchEventID, PassRefPtr<WebCore::Respo nse>) OVERRIDE;

49 virtual void didHandleSyncEvent(int syncEventID) OVERRIDE;	49 virtual void didHandleSyncEvent(int syncEventID) OVERRIDE;

50	50

51 virtual void trace(WebCore::Visitor*) OVERRIDE	51 virtual void trace(WebCore::Visitor*) OVERRIDE { }

52 {

53 // FIXME: Oilpan: Move WorkerClients to the managed heap before using th is trace method.

54 }

55	52

56 private:	53 private:

57 ServiceWorkerGlobalScopeClientImpl(PassOwnPtr<WebServiceWorkerContextClient> );	54 ServiceWorkerGlobalScopeClientImpl(PassOwnPtr<WebServiceWorkerContextClient> );

58	55

59 OwnPtr<WebServiceWorkerContextClient> m_client;	56 OwnPtr<WebServiceWorkerContextClient> m_client;

60 };	57 };

61	58

62 } // namespace blink	59 } // namespace blink

63	60

64 #endif // ServiceWorkerGlobalScopeClientImpl_h	61 #endif // ServiceWorkerGlobalScopeClientImpl_h

OLD	NEW