Source/modules/serviceworkers/ServiceWorkerContainerClient.h - Issue 230083003: Oilpan: Move WorkerClients to the managed heap and trace its supplements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainerClient.h

Issue 230083003: Oilpan: Move WorkerClients to the managed heap and trace its supplements. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: CR comments and unbreak the non-oilpan build Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/serviceworkers/ServiceWorkerContainerClient.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainerClient.h b/Source/modules/serviceworkers/ServiceWorkerContainerClient.h

index 1df2b6204b2266706b04811f96d163f4faa9b5ac..f566b7126b57d37b68b1150df9f3feb48d0c425d 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainerClient.h

+++ b/Source/modules/serviceworkers/ServiceWorkerContainerClient.h

@@ -32,10 +32,7 @@ public:

static const char* supplementName();

static ServiceWorkerContainerClient* from(ExecutionContext*);

- virtual void trace(Visitor*) OVERRIDE

- {

- // FIXME: Oilpan: Move WorkerClients to the managed heap before using this trace method.

- }

+ virtual void trace(Visitor*) OVERRIDE { }

protected:

explicit ServiceWorkerContainerClient(PassOwnPtr<blink::WebServiceWorkerProvider>);