Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2298963002: Material Page Info (Mac, 3/3): Update site settings section. (Closed)

Created:
4 years, 3 months ago by lgarron
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material Page Info (Mac, 3/3): Update site settings section. BUG=512442 Committed: https://crrev.com/f9714c66fa583e02eebe807ac5b82d01813efbd4 Cr-Commit-Position: refs/heads/master@{#417828}

Patch Set 1 #

Patch Set 2 : Material Page Info (Mac, 3/3): Update site settings section. #

Patch Set 3 : Material Page Info (Mac, 3/3): Update site settings section. #

Patch Set 4 : Fix variable. #

Patch Set 5 : Update WSBC tests to compensate for removing the Permissions label. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -144 lines) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 2 3 4 19 chunks +94 lines, -139 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm View 1 2 3 4 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
lgarron
... and #3. avi@, would you mind reviewing? :-) This is a followup to: https://codereview.chromium.org/2283753003 ...
4 years, 3 months ago (2016-09-01 20:30:03 UTC) #3
Avi (use Gerrit)
lgtm ok
4 years, 3 months ago (2016-09-01 20:57:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298963002/60001
4 years, 3 months ago (2016-09-10 07:11:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/294227)
4 years, 3 months ago (2016-09-10 08:09:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298963002/80001
4 years, 3 months ago (2016-09-10 08:12:18 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-10 09:13:14 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 09:15:23 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f9714c66fa583e02eebe807ac5b82d01813efbd4
Cr-Commit-Position: refs/heads/master@{#417828}

Powered by Google App Engine
This is Rietveld 408576698