Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

Issue 2298963002: Material Page Info (Mac, 3/3): Update site settings section. (Closed)
Patch Set: Update WSBC tests to compensate for removing the Permissions label. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
index 911319d707a23427a7f085959319c0e0d5df02a7..078212964fbb8d5867387dc9e3960a857d5ea3d4 100644
--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
@@ -252,10 +252,9 @@ TEST_F(WebsiteSettingsBubbleControllerTest, SetPermissionInfo) {
CreateBubble();
SetTestPermissions();
- // There should be three subviews per permission (an icon, a label and a
- // select box), plus a text label for the Permission section.
+ // There should be three subviews per permission.
NSArray* subviews = [[controller_ permissionsView] subviews];
- EXPECT_EQ(arraysize(kTestPermissionTypes) * 3 + 1, [subviews count]);
+ EXPECT_EQ(arraysize(kTestPermissionTypes) * 3 , [subviews count]);
// Ensure that there is a distinct label for each permission.
NSMutableSet* labels = [NSMutableSet set];
@@ -263,8 +262,7 @@ TEST_F(WebsiteSettingsBubbleControllerTest, SetPermissionInfo) {
if ([view isKindOfClass:[NSTextField class]])
[labels addObject:[static_cast<NSTextField*>(view) stringValue]];
}
- // The section header ("Permissions") will also be found, hence the +1.
- EXPECT_EQ(arraysize(kTestPermissionTypes) + 1, [labels count]);
+ EXPECT_EQ(arraysize(kTestPermissionTypes), [labels count]);
// Ensure that the button labels are distinct, and look for the correct
// number of disabled buttons.
« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698