Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2285683003: Material Page Info (Mac, 2/3): Update security section. (Closed)

Created:
4 years, 3 months ago by lgarron
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material Page Info (Mac, 2/3): Update security section. - Add a security summary. - Update the security details paragraph. - Change the certificate decision button to an explanation and a link. The first two bullets depend on string changes in https://codereview.chromium.org/2262223002 BUG=512442 Committed: https://crrev.com/d1799faaa8308b8591822e758d41c86e408f9f9a Cr-Commit-Position: refs/heads/master@{#417823}

Patch Set 1 #

Patch Set 2 : Remove TODO. #

Patch Set 3 : Fix padding based on dependent CL. #

Patch Set 4 : Update security section. #

Patch Set 5 : Material Page Info (Mac, 2/3): Update security section. #

Patch Set 6 : Remove coloring. #

Patch Set 7 : Remove obsolete tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -63 lines) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h View 1 2 3 4 5 3 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 2 3 4 5 6 chunks +55 lines, -27 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm View 1 2 3 4 5 6 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
lgarron
avi@, could you review? This CL follows https://codereview.chromium.org/2283753003
4 years, 3 months ago (2016-09-01 20:17:28 UTC) #5
Avi (use Gerrit)
lgtm OK.
4 years, 3 months ago (2016-09-01 20:20:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285683003/100001
4 years, 3 months ago (2016-09-10 03:44:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/294199)
4 years, 3 months ago (2016-09-10 04:41:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285683003/120001
4 years, 3 months ago (2016-09-10 06:14:18 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-09-10 06:59:20 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 07:01:22 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/d1799faaa8308b8591822e758d41c86e408f9f9a
Cr-Commit-Position: refs/heads/master@{#417823}

Powered by Google App Engine
This is Rietveld 408576698