Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2283753003: Material page info (Mac, 1/3): Update section padding variables. (Closed)

Created:
4 years, 3 months ago by lgarron
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material page info (Mac, 1/3): Update section padding variables. This is in its own commit so that the commits for the two Page Info sections are easier to understand. BUG=512442 Committed: https://crrev.com/e5a4a06e5259673ae0e7381aa9ca0166739f52d0 Cr-Commit-Position: refs/heads/master@{#416405}

Patch Set 1 #

Patch Set 2 : Move padding inside each section's view to avoid text clipping in later CLs. #

Patch Set 3 : Move internal constants, since that makes more sense in this CL than the immediate followup CLs. #

Patch Set 4 : Also move constant grouping comments into this CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -43 lines) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 2 3 21 chunks +55 lines, -43 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
lgarron
rsesek@ is still out; avi@, would you mind taking a look?
4 years, 3 months ago (2016-09-01 20:16:19 UTC) #8
Avi (use Gerrit)
lgtm Looks reasonable.
4 years, 3 months ago (2016-09-01 20:18:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283753003/60001
4 years, 3 months ago (2016-09-02 23:28:12 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-03 00:10:38 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 00:14:36 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e5a4a06e5259673ae0e7381aa9ca0166739f52d0
Cr-Commit-Position: refs/heads/master@{#416405}

Powered by Google App Engine
This is Rietveld 408576698