Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2298473003: DevTools: do not leak memory through event listeners (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not leak memory through event listeners EventListeners array hold references to the objects which they were listening to, preventing them from being cleaned up. BUG=none R=dgozman Committed: https://crrev.com/86b94ffee79cb6ad57adcdbf6af8dea839a9b729 Cr-Commit-Position: refs/heads/master@{#415545}

Patch Set 1 #

Patch Set 2 : cleanup - some clients have being cleaning event listeners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Object.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
lushnikov
Dmitry, this is a follow-up to our offline discussion. In fact, I think that we ...
4 years, 3 months ago (2016-08-30 21:42:28 UTC) #1
dgozman
I like this patch! I think it will save us later. lgtm
4 years, 3 months ago (2016-08-30 23:00:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298473003/20001
4 years, 3 months ago (2016-08-31 00:52:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 02:47:40 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 02:49:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86b94ffee79cb6ad57adcdbf6af8dea839a9b729
Cr-Commit-Position: refs/heads/master@{#415545}

Powered by Google App Engine
This is Rietveld 408576698