third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js - Issue 2298473003: DevTools: do not leak memory through event listeners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js

Issue 2298473003: DevTools: do not leak memory through event listeners (Closed)

Patch Set: cleanup - some clients have being cleaning event listeners Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js b/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js

index 8b15f9f4ab053fe1304a81936ff5b95a4c5d2f8e..5546b92f8be5cc07b162dd3d0e3ed2353c471e62 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js

@@ -400,7 +400,6 @@ WebInspector.NetworkProject.prototype = {

{

this._reset();

WebInspector.EventTarget.removeEventListeners(this._eventListeners);

- this._eventListeners = [];

delete this.target()[WebInspector.NetworkProject._networkProjectSymbol];

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/common/Object.js » ('j') | no next file with comments »