third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js - Issue 2298473003: DevTools: do not leak memory through event listeners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js

Issue 2298473003: DevTools: do not leak memory through event listeners (Closed)

Patch Set: cleanup - some clients have being cleaning event listeners Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js b/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js

index 28481096aa90990f27ba8bd4306a5b3dd2002fd2..e702b30fa0099e42351e5b94d3fb1afe3f6cc922 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js

@@ -52,10 +52,8 @@ WebInspector.ComputedStyleModel.prototype = {

{

if (this._target === target)

return;

- if (this._targetEvents) {

+ if (this._targetEvents)

WebInspector.EventTarget.removeEventListeners(this._targetEvents);

- this._targetEvents = null;

- }

this._target = target;

var domModel = null;

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/common/Object.js ('k') | no next file » | no next file with comments »