third_party/WebKit/Source/devtools/front_end/common/Object.js - Issue 2298473003: DevTools: do not leak memory through event listeners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/common/Object.js

Issue 2298473003: DevTools: do not leak memory through event listeners (Closed)

Patch Set: cleanup - some clients have being cleaning event listeners Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/common/Object.js

diff --git a/third_party/WebKit/Source/devtools/front_end/common/Object.js b/third_party/WebKit/Source/devtools/front_end/common/Object.js

index bba17b44d10ec931a83ad3387f2394d93be800ab..86495350547ee75a4d050eeab26791ea2c9dbef9 100644

--- a/third_party/WebKit/Source/devtools/front_end/common/Object.js

+++ b/third_party/WebKit/Source/devtools/front_end/common/Object.js

@@ -167,6 +167,8 @@ WebInspector.EventTarget.removeEventListeners = function(eventList)

var eventInfo = eventList[i];

eventInfo.eventTarget.removeEventListener(eventInfo.eventType, eventInfo.method, eventInfo.receiver);

}

+ // Do not hold references on unused event descriptors.

+ eventList.splice(0, eventList.length);

}

WebInspector.EventTarget.prototype = {