Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2295693004: Pass JavaRef to Java methods in android_webview. (Closed)

Created:
4 years, 3 months ago by Torne
Modified:
4 years, 3 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass JavaRef to Java methods in android_webview. Update code in android_webview to use JavaRef when calling Java methods via JNI, instead of passing bare jobject. Various function parameter types are converted from jobject to JavaRef to enable calls to obj() higher up the call chain to be removed. BUG=506850 Committed: https://crrev.com/1c12b81fcf9cf40d2155e950e56cf61e0ebb97b0 Cr-Commit-Position: refs/heads/master@{#416234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -63 lines) Patch
M android_webview/native/aw_autofill_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M android_webview/native/aw_contents_background_thread_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/native/aw_contents_background_thread_client.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.h View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M android_webview/native/aw_contents_statics.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_message_port_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_pdf_exporter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_pdf_exporter.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M android_webview/native/aw_settings.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M android_webview/native/input_stream_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/input_stream_impl.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Torne
Followup to https://codereview.chromium.org/2237943002/ where I removed all the .obj() calls that could be removed mechanically. ...
4 years, 3 months ago (2016-08-31 16:56:49 UTC) #2
sgurun-gerrit only
On 2016/08/31 16:56:49, Torne wrote: > Followup to https://codereview.chromium.org/2237943002/ where I removed all the > ...
4 years, 3 months ago (2016-09-02 05:48:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295693004/1
4 years, 3 months ago (2016-09-02 10:35:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 11:14:55 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 11:17:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c12b81fcf9cf40d2155e950e56cf61e0ebb97b0
Cr-Commit-Position: refs/heads/master@{#416234}

Powered by Google App Engine
This is Rietveld 408576698