Pass JavaRef to Java methods in android_webview.

android_webview/native/input_stream_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/input_stream_impl.h"
 
 #include "base/android/jni_android.h"
 // Disable "Warnings treated as errors" for input_stream_jni as it's a Java
 // system class and we have to generate C++ hooks for all methods in the class
 // even if they're unused.
@@ skipping 67 matching lines @@
     // Allocate transfer buffer.
     base::android::ScopedJavaLocalRef<jbyteArray> temp(
         env, env->NewByteArray(kBufferSize));
     buffer_.Reset(temp);
     if (ClearException(env))
       return false;
   }
 
   int remaining_length = length;
   char* dest_write_ptr = dest->data();
-  jbyteArray buffer = buffer_.obj();
   *bytes_read = 0;
 
   while (remaining_length > 0) {
     const int max_transfer_length = std::min(remaining_length, kBufferSize);
     const int transfer_length = Java_InputStreamUtil_read(
-        env, jobject_, buffer, 0, max_transfer_length);
+        env, jobject_, buffer_, 0, max_transfer_length);
     if (transfer_length == kExceptionThrownStatusCode)
       return false;
 
     if (transfer_length < 0)  // EOF
       break;
 
     // Note: it is possible, yet unlikely, that the Java InputStream returns
     // a transfer_length == 0 from time to time. In such cases we just continue
     // the read until we get either valid data or reach EOF.
     if (transfer_length == 0)
       continue;
 
     DCHECK_GE(max_transfer_length, transfer_length);
-    DCHECK_GE(env->GetArrayLength(buffer), transfer_length);
+    DCHECK_GE(env->GetArrayLength(buffer_.obj()), transfer_length);
 
     // This check is to prevent a malicious InputStream implementation from
     // overrunning the |dest| buffer.
     if (transfer_length > max_transfer_length)
       return false;
 
     // Copy the data over to the provided C++ IOBuffer.
     DCHECK_GE(remaining_length, transfer_length);
-    env->GetByteArrayRegion(buffer, 0, transfer_length,
-        reinterpret_cast<jbyte*>(dest_write_ptr));
+    env->GetByteArrayRegion(buffer_.obj(), 0, transfer_length,
+                            reinterpret_cast<jbyte*>(dest_write_ptr));
     if (ClearException(env))
       return false;
 
     remaining_length -= transfer_length;
     dest_write_ptr += transfer_length;
   }
   // bytes_read can be strictly less than the req. length if EOF is encountered.
   DCHECK_GE(remaining_length, 0);
   DCHECK_LE(remaining_length, length);
   *bytes_read = length - remaining_length;
   return true;
 }
 
 } // namespace android_webview