Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2299693002: Allow nullptr to be converted to JavaRef subclasses. (Closed)

Created:
4 years, 3 months ago by Torne
Modified:
4 years, 3 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow nullptr to be converted to JavaRef subclasses. nullptr can already be converted to JavaRef; also allow it to be converted to ScopedJavaLocalRef and ScopedJavaGlobalRef, as otherwise certain constructs (like use of the ternary operator) fail to deduce types correctly. BUG= Committed: https://crrev.com/0fce7cca2e2e93baf56f28c98fe756b7d88a4c79 Cr-Commit-Position: refs/heads/master@{#415808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/android/scoped_java_ref.h View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Torne
4 years, 3 months ago (2016-08-31 16:50:02 UTC) #2
nyquist
omg lgtm thanksverymuch
4 years, 3 months ago (2016-08-31 22:17:14 UTC) #3
nyquist
I saw you had a dependent patch so I CQed it for you.
4 years, 3 months ago (2016-08-31 22:17:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299693002/1
4 years, 3 months ago (2016-08-31 22:18:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 23:51:11 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 23:53:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fce7cca2e2e93baf56f28c98fe756b7d88a4c79
Cr-Commit-Position: refs/heads/master@{#415808}

Powered by Google App Engine
This is Rietveld 408576698