[Offline Pages] Check for the appropriate namespace when showing notifications.

[Offline Pages] Check for the appropriate namespace when showing notifications.

Download notifications should only be shown for pages in the namespaces that
will be shown in the Download Home.

BUG=642019
Committed: https://crrev.com/955a6d528e7c81b0f3023dd9adc3ebdddcfaa294
Cr-Commit-Position: refs/heads/master@{#415444}

[dewittj, 2016-08-30 01:27:32]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[dewittj, 2016-08-30 02:02:12]

Description was changed from

==========
[Offline Pages] Check for the appropriate namespace when showing notifications.

Download notifications should only be shown for pages in the namespaces that
will be shown in the Download Home.

BUG=642019
==========

to

==========
[Offline Pages] Check for the appropriate namespace when showing notifications.

Download notifications should only be shown for pages in the namespaces that
will be shown in the Download Home.

BUG=642019
==========

[dewittj, 2016-08-30 02:02:12]

dewittj@chromium.org changed reviewers:
+ fgorski@chromium.org

[dewittj, 2016-08-30 02:02:19]

ptal, thanks

[commit-bot: I haz the power, 2016-08-30 02:20:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:50:58]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-08-30 16:21:29]

lgtm

https://codereview.chromium.org/2295593002/diff/1/components/offline_pages/do...
File components/offline_pages/downloads/download_notifying_observer_unittest.cc
(right):

https://codereview.chromium.org/2295593002/diff/1/components/offline_pages/do...
components/offline_pages/downloads/download_notifying_observer_unittest.cc:231:
TEST_F(DownloadNotifyingObserverTest, VisibleInUI) {
nit: NamepsacesNotVisibleInUI

[dewittj, 2016-08-30 16:29:08]

https://codereview.chromium.org/2295593002/diff/1/components/offline_pages/do...
File components/offline_pages/downloads/download_notifying_observer_unittest.cc
(right):

https://codereview.chromium.org/2295593002/diff/1/components/offline_pages/do...
components/offline_pages/downloads/download_notifying_observer_unittest.cc:231:
TEST_F(DownloadNotifyingObserverTest, VisibleInUI) {
On 2016/08/30 16:21:29, fgorski wrote:
> nit: NamepsacesNotVisibleInUI

Done.

[dewittj, 2016-08-30 16:29:10]

The CQ bit was checked by dewittj@chromium.org

[dewittj, 2016-08-30 16:29:11]

The patchset sent to the CQ was uploaded after l-g-t-m from fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2295593002/#ps20001
(title: "Rename test.")

[commit-bot: I haz the power, 2016-08-30 16:29:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2016-08-30 16:35:08]

dimich@chromium.org changed reviewers:
+ dimich@chromium.org

[Dmitry Titov, 2016-08-30 16:35:09]

https://codereview.chromium.org/2295593002/diff/20001/components/offline_page...
File components/offline_pages/downloads/download_notifying_observer.cc (right):

https://codereview.chromium.org/2295593002/diff/20001/components/offline_page...
components/offline_pages/downloads/download_notifying_observer.cc:17: bool
IsVisibleInUI(const ClientId& client_id) {
Any reason not to make this function public static and use here? 

https://cs.chromium.org/chromium/src/components/offline_pages/downloads/downl...

[dewittj, 2016-08-30 16:36:19]

The CQ bit was unchecked by dewittj@chromium.org

[dewittj, 2016-08-30 16:51:44]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 16:52:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-08-30 16:52:09]

ptal, thanks

[dewittj, 2016-08-30 16:52:24]

https://codereview.chromium.org/2295593002/diff/20001/components/offline_page...
File components/offline_pages/downloads/download_notifying_observer.cc (right):

https://codereview.chromium.org/2295593002/diff/20001/components/offline_page...
components/offline_pages/downloads/download_notifying_observer.cc:17: bool
IsVisibleInUI(const ClientId& client_id) {
On 2016/08/30 16:35:09, Dmitry Titov wrote:
> Any reason not to make this function public static and use here? 
> 
>
https://cs.chromium.org/chromium/src/components/offline_pages/downloads/downl...

Done.

[Dmitry Titov, 2016-08-30 17:21:14]

lgtm with a nit:

I think the IsVisibleinUI function should gain "//static" comment in /cc file.

[commit-bot: I haz the power, 2016-08-30 17:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 17:41:20]

Dry run: This issue passed the CQ dry run.

[dewittj, 2016-08-30 19:58:51]

The CQ bit was checked by dewittj@chromium.org

[dewittj, 2016-08-30 19:58:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
fgorski@chromium.org, dimich@chromium.org
Link to the patchset: https://codereview.chromium.org/2295593002/#ps60001
(title: "Add comment.")

[commit-bot: I haz the power, 2016-08-30 19:59:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 21:50:18]

Description was changed from

==========
[Offline Pages] Check for the appropriate namespace when showing notifications.

Download notifications should only be shown for pages in the namespaces that
will be shown in the Download Home.

BUG=642019
==========

to

==========
[Offline Pages] Check for the appropriate namespace when showing notifications.

Download notifications should only be shown for pages in the namespaces that
will be shown in the Download Home.

BUG=642019
==========

[commit-bot: I haz the power, 2016-08-30 21:50:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-30 21:53:52]

Description was changed from

==========
[Offline Pages] Check for the appropriate namespace when showing notifications.

Download notifications should only be shown for pages in the namespaces that
will be shown in the Download Home.

BUG=642019
==========

to

==========
[Offline Pages] Check for the appropriate namespace when showing notifications.

Download notifications should only be shown for pages in the namespaces that
will be shown in the Download Home.

BUG=642019

Committed: https://crrev.com/955a6d528e7c81b0f3023dd9adc3ebdddcfaa294
Cr-Commit-Position: refs/heads/master@{#415444}
==========

[commit-bot: I haz the power, 2016-08-30 21:53:54]

Patchset 4 (id:??) landed as
https://crrev.com/955a6d528e7c81b0f3023dd9adc3ebdddcfaa294
Cr-Commit-Position: refs/heads/master@{#415444}