Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: components/offline_pages/downloads/download_ui_adapter.h

Issue 2295593002: [Offline Pages] Check for the appropriate namespace when showing notifications. (Closed)
Patch Set: Add comment. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/downloads/download_ui_adapter.h
diff --git a/components/offline_pages/downloads/download_ui_adapter.h b/components/offline_pages/downloads/download_ui_adapter.h
index a8ea99be966218913d20a2441b1f309a78e3f666..20c9e3ea9a382950935b9dbfa68c90f767e3db60 100644
--- a/components/offline_pages/downloads/download_ui_adapter.h
+++ b/components/offline_pages/downloads/download_ui_adapter.h
@@ -56,6 +56,10 @@ class DownloadUIAdapter : public OfflinePageModel::Observer,
static DownloadUIAdapter* FromOfflinePageModel(
OfflinePageModel* offline_page_model);
+ // Checks a client ID for proper namespace and ID format to be shown in the
+ // Downloads Home UI.
+ static bool IsVisibleInUI(const ClientId& page);
+
// This adapter is potentially shared by UI elements, each of which adds
// itself as an observer.
// When the last observer si removed, cached list of items is destroyed and
@@ -111,8 +115,6 @@ class DownloadUIAdapter : public OfflinePageModel::Observer,
void OnOfflinePagesChanged(const MultipleOfflinePageItemResult& pages);
void OnDeletePagesDone(DeletePageResult result);
- bool IsVisibleInUI(const ClientId& page);
-
// Always valid, this class is a member of the model.
OfflinePageModel* model_;

Powered by Google App Engine
This is Rietveld 408576698