[Offline Pages] Check for the appropriate namespace when showing notifications.

components/offline_pages/downloads/download_notifying_observer_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/downloads/download_notifying_observer.h"
 
 #include "base/memory/ptr_util.h"
 #include "components/offline_pages/background/save_page_request.h"
 #include "components/offline_pages/client_namespace_constants.h"
 #include "components/offline_pages/downloads/offline_page_download_notifier.h"
@@ skipping 210 matching lines @@
   notifier()->Reset();
   observer()->OnCompleted(
       request, RequestNotifier::SavePageStatus::RETRY_COUNT_EXCEEDED);
   EXPECT_EQ(LastNotificationType::DOWNLOAD_FAILED,
             notifier()->last_notification_type());
   EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
   EXPECT_EQ(GURL(kTestUrl), notifier()->download_item()->url);
   EXPECT_EQ(kTestCreationTime, notifier()->download_item()->start_time);
 }
 
+TEST_F(DownloadNotifyingObserverTest, VisibleInUI) {

[fgorski, 2016/08/30 16:21:29]

nit: NamepsacesNotVisibleInUI

[dewittj, 2016/08/30 16:29:08]

Done.

+  std::vector<std::string> name_spaces = {
+      kBookmarkNamespace, kLastNNamespace, kCCTNamespace,
+      kNTPSuggestionsNamespace, kDefaultNamespace};
+
+  for (auto name_space : name_spaces) {
+    ClientId invisible_client_id(name_space, kTestGuid);
+    SavePageRequest request(kTestOfflineId, GURL(kTestUrl), invisible_client_id,
+                            kTestCreationTime, kTestUserRequested);
+    observer()->OnAdded(request);
+    EXPECT_EQ(LastNotificationType::NONE, notifier()->last_notification_type());
+  }
+}
+
 }  // namespace offline_pages