[Offline Pages] Check for the appropriate namespace when showing notifications.

components/offline_pages/downloads/download_notifying_observer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/downloads/download_notifying_observer.h"
 
+#include "base/guid.h"
 #include "components/offline_pages/background/request_coordinator.h"
 #include "components/offline_pages/background/save_page_request.h"
+#include "components/offline_pages/client_namespace_constants.h"
 #include "components/offline_pages/downloads/offline_page_download_notifier.h"
 
 namespace offline_pages {
 namespace {
 int kUserDataKey;  // Only address is used.
+
+bool IsVisibleInUI(const ClientId& client_id) {

[Dmitry Titov, 2016/08/30 16:35:09]

Any reason not to make this function public static and use here? 

https://cs.chromium.org/chromium/src/components/offline_pages/downloads/downl...

[dewittj, 2016/08/30 16:52:24]

Done.

+  const std::string& name_space = client_id.name_space;
+  return (name_space == kAsyncNamespace || name_space == kDownloadNamespace) &&
+         base::IsValidGUID(client_id.id);
+}
+
 }  // namespace
 
 DownloadNotifyingObserver::DownloadNotifyingObserver(
     std::unique_ptr<OfflinePageDownloadNotifier> notifier)
     : notifier_(std::move(notifier)) {}
 
 DownloadNotifyingObserver::~DownloadNotifyingObserver() {}
 
 // static
 DownloadNotifyingObserver* DownloadNotifyingObserver::GetFromRequestCoordinator(
@@ skipping 11 matching lines @@
   DCHECK(notifier.get());
   DownloadNotifyingObserver* observer =
       new DownloadNotifyingObserver(std::move(notifier));
   request_coordinator->AddObserver(observer);
   // |request_coordinator| takes ownership of observer here.
   request_coordinator->SetUserData(&kUserDataKey, observer);
 }
 
 void DownloadNotifyingObserver::OnAdded(const SavePageRequest& request) {
   DCHECK(notifier_.get());
+  if (!IsVisibleInUI(request.client_id()))
+    return;
   notifier_->NotifyDownloadProgress(DownloadUIItem(request));
 }
 
 void DownloadNotifyingObserver::OnChanged(const SavePageRequest& request) {
   DCHECK(notifier_.get());
+  if (!IsVisibleInUI(request.client_id()))
+    return;
   if (request.request_state() == SavePageRequest::RequestState::PAUSED)
     notifier_->NotifyDownloadPaused(DownloadUIItem(request));
   else
     notifier_->NotifyDownloadProgress(DownloadUIItem(request));
 }
 
 void DownloadNotifyingObserver::OnCompleted(
     const SavePageRequest& request,
     RequestCoordinator::SavePageStatus status) {
   DCHECK(notifier_.get());
+  if (!IsVisibleInUI(request.client_id()))
+    return;
   if (status == RequestCoordinator::SavePageStatus::SUCCESS)
     notifier_->NotifyDownloadSuccessful(DownloadUIItem(request));
   else if (status == RequestCoordinator::SavePageStatus::REMOVED)
     notifier_->NotifyDownloadCanceled(DownloadUIItem(request));
   else
     notifier_->NotifyDownloadFailed(DownloadUIItem(request));
 }
 }  // namespace offline_pages