Chrome::client() should return a ChromeClient reference.

Chrome::client() should return a ChromeClient reference.

It is never null. We can remove some unnecessary null checks.

BUG=none
TEST=none; no behavior changes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156375

[pdr., 2013-08-20 06:32:58]

On 2013/08/20 06:12:57, tkent wrote:

Is this a merge of http://trac.webkit.org/changeset/154142? If so, we should
mention this is a merge in the change description and give credit to the
original author.

[tkent, 2013-08-20 06:39:18]

On 2013/08/20 06:32:58, pdr wrote:
> On 2013/08/20 06:12:57, tkent wrote:
> 
> Is this a merge of http://trac.webkit.org/changeset/154142? If so, we should
> mention this is a merge in the change description and give credit to the
> original author.

154142 looks unrelated to ChromeClient.  Anyway, this CL isn't a merge of a
WebKit change. I made this by myself.

[yosin_UTC9, 2013-08-20 08:02:47]

LGTM

BTW, can we rename Chrome/ChromeClient to another names? When I was a new to
WebKit, it made me confusing...

[commit-bot: I haz the power, 2013-08-20 08:23:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/22955006/1

[commit-bot: I haz the power, 2013-08-20 08:27:00]

Change committed as 156375

[tkent, 2013-08-20 08:30:26]

On 2013/08/20 08:02:47, Yoshifumi Inoue wrote:
> LGTM
> 
> BTW, can we rename Chrome/ChromeClient to another names? When I was a new to
> WebKit, it made me confusing...

I think Chrome is the best name for some functions such as setWindowFeatures,
toolbarVisible, statusbarVisible, ...
Other functions can be separated to another interface. We might want to move
createColorChooser, openDateTimeChooser, runOpenPanel, etc. to new
FormUIController.