Source/core/loader/FrameLoader.cpp - Issue 22955006: Chrome::client() should return a ChromeClient reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 22955006: Chrome::client() should return a ChromeClient reference. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/FrameLoader.cpp

diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp

index a67a999fe91412eda3b9bc5e5ab53cf906c1e342..837743a9507b1af250088591ffc1a8ce08844601 100644

--- a/Source/core/loader/FrameLoader.cpp

+++ b/Source/core/loader/FrameLoader.cpp

@@ -985,7 +985,7 @@ void FrameLoader::commitProvisionalLoad()

m_state = FrameStateCommittedPage;

if (isLoadingMainFrame())

- m_frame->page()->chrome().client()->needTouchEvents(false);

+ m_frame->page()->chrome().client().needTouchEvents(false);

history()->updateForCommit();

m_client->transitionToCommittedForNewPage();

@@ -1535,7 +1535,7 @@ void FrameLoader::checkNewWindowPolicyAndContinue(PassRefPtr<FormState> formStat

if (!m_frame->settings() || m_frame->settings()->supportsMultipleWindows()) {

struct WindowFeatures features;

- Page* newPage = m_frame->page()->chrome().client()->createWindow(m_frame, FrameLoadRequest(m_frame->document()->securityOrigin(), action.resourceRequest()),

+ Page* newPage = m_frame->page()->chrome().client().createWindow(m_frame, FrameLoadRequest(m_frame->document()->securityOrigin(), action.resourceRequest()),

features, navigationPolicy);

// createWindow can return null (e.g., popup blocker denies the window).

« no previous file with comments | « Source/core/inspector/InspectorOverlay.cpp ('k') | Source/core/page/Chrome.h » ('j') | no next file with comments »