Source/core/html/PasswordInputType.cpp - Issue 22955006: Chrome::client() should return a ChromeClient reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/PasswordInputType.cpp

Issue 22955006: Chrome::client() should return a ChromeClient reference. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/PasswordInputType.cpp

diff --git a/Source/core/html/PasswordInputType.cpp b/Source/core/html/PasswordInputType.cpp

index 94518ed79a538d91ae10dba2ce04638a72a6c72f..08cc5ba88b77a4a906762251553149410c48dd7c 100644

--- a/Source/core/html/PasswordInputType.cpp

+++ b/Source/core/html/PasswordInputType.cpp

@@ -55,9 +55,9 @@ HTMLElement* PasswordInputType::passwordGeneratorButtonElement() const

bool PasswordInputType::isPasswordGenerationEnabled() const

{

- Document* document = element()->document();

- ChromeClient* chromeClient = document->page() ? document->page()->chrome().client() : 0;

- return chromeClient && chromeClient->isPasswordGenerationEnabled();

+ if (Page* page = element()->document()->page())

+ return page->chrome().client().isPasswordGenerationEnabled();

+ return false;

}

bool PasswordInputType::needsContainer() const