Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 2295043004: Make QUIC tests restore flags to their default values (Closed)

Created:
4 years, 3 months ago by Ryan Hamilton
Modified:
4 years, 3 months ago
Reviewers:
justincohen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make QUIC tests restore flags to their default values BUG=642709 Committed: https://crrev.com/133d059ec4a832e0c6c582e41ea6610814c2d88d Cr-Commit-Position: refs/heads/master@{#415779}

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : remove the workaround #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M net/quic/chromium/quic_end_to_end_unittest.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_protocol_test.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ryan Hamilton
4 years, 3 months ago (2016-08-31 21:34:25 UTC) #2
justincohen
rs lgtm
4 years, 3 months ago (2016-08-31 21:40:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295043004/40001
4 years, 3 months ago (2016-08-31 21:43:25 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 22:22:21 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:24:39 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/133d059ec4a832e0c6c582e41ea6610814c2d88d
Cr-Commit-Position: refs/heads/master@{#415779}

Powered by Google App Engine
This is Rietveld 408576698