Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: net/quic/chromium/quic_end_to_end_unittest.cc

Issue 2295043004: Make QUIC tests restore flags to their default values (Closed)
Patch Set: remove the workaround Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/chromium/quic_network_transaction_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 #include <ostream> 6 #include <ostream>
7 #include <utility> 7 #include <utility>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 protected: 100 protected:
101 QuicEndToEndTest() 101 QuicEndToEndTest()
102 : host_resolver_impl_(CreateResolverImpl()), 102 : host_resolver_impl_(CreateResolverImpl()),
103 host_resolver_(std::move(host_resolver_impl_)), 103 host_resolver_(std::move(host_resolver_impl_)),
104 cert_transparency_verifier_(new MultiLogCTVerifier()), 104 cert_transparency_verifier_(new MultiLogCTVerifier()),
105 ssl_config_service_(new SSLConfigServiceDefaults), 105 ssl_config_service_(new SSLConfigServiceDefaults),
106 proxy_service_(ProxyService::CreateDirect()), 106 proxy_service_(ProxyService::CreateDirect()),
107 auth_handler_factory_( 107 auth_handler_factory_(
108 HttpAuthHandlerFactory::CreateDefault(&host_resolver_)), 108 HttpAuthHandlerFactory::CreateDefault(&host_resolver_)),
109 strike_register_no_startup_period_(false) { 109 strike_register_no_startup_period_(false) {
110 // TODO(crbug.com/642709) These values are currently needed to avoid test
111 // test failures on iOS10. It's unclear why this is happenening, and should
112 // be removed after investigation.
113 FLAGS_quic_enable_version_35 = true;
114 FLAGS_quic_enable_version_36 = true;
115 FLAGS_quic_enable_version_36_v2 = true;
116
117 request_.method = "GET"; 110 request_.method = "GET";
118 request_.url = GURL("https://test.example.com/"); 111 request_.url = GURL("https://test.example.com/");
119 request_.load_flags = 0; 112 request_.load_flags = 0;
120 113
121 params_.enable_quic = true; 114 params_.enable_quic = true;
122 params_.quic_clock = nullptr; 115 params_.quic_clock = nullptr;
123 params_.quic_random = nullptr; 116 params_.quic_random = nullptr;
124 if (GetParam().use_stateless_rejects) { 117 if (GetParam().use_stateless_rejects) {
125 params_.quic_connection_options.push_back(kSREJ); 118 params_.quic_connection_options.push_back(kSREJ);
126 } 119 }
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 base::RunLoop().Run(); 364 base::RunLoop().Run();
372 365
373 for (size_t i = 0; i < num_requests; ++i) { 366 for (size_t i = 0; i < num_requests; ++i) {
374 CheckResponse(*consumers[i], "HTTP/1.1 200", kResponseBody); 367 CheckResponse(*consumers[i], "HTTP/1.1 200", kResponseBody);
375 } 368 }
376 base::STLDeleteElements(&consumers); 369 base::STLDeleteElements(&consumers);
377 } 370 }
378 371
379 } // namespace test 372 } // namespace test
380 } // namespace net 373 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/quic/chromium/quic_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698