Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: net/quic/chromium/quic_end_to_end_unittest.cc

Issue 2295043004: Make QUIC tests restore flags to their default values (Closed)
Patch Set: remove the workaround Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/quic_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_end_to_end_unittest.cc
diff --git a/net/quic/chromium/quic_end_to_end_unittest.cc b/net/quic/chromium/quic_end_to_end_unittest.cc
index 1a14290f358d0dbffd8ad25354868379a12eec9b..cd551f14c005b2b0711a0e8b2a337955e32038e5 100644
--- a/net/quic/chromium/quic_end_to_end_unittest.cc
+++ b/net/quic/chromium/quic_end_to_end_unittest.cc
@@ -107,13 +107,6 @@ class QuicEndToEndTest : public ::testing::TestWithParam<TestParams> {
auth_handler_factory_(
HttpAuthHandlerFactory::CreateDefault(&host_resolver_)),
strike_register_no_startup_period_(false) {
- // TODO(crbug.com/642709) These values are currently needed to avoid test
- // test failures on iOS10. It's unclear why this is happenening, and should
- // be removed after investigation.
- FLAGS_quic_enable_version_35 = true;
- FLAGS_quic_enable_version_36 = true;
- FLAGS_quic_enable_version_36_v2 = true;
-
request_.method = "GET";
request_.url = GURL("https://test.example.com/");
request_.load_flags = 0;
« no previous file with comments | « no previous file | net/quic/chromium/quic_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698