Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: net/quic/core/quic_protocol_test.cc

Issue 2295043004: Make QUIC tests restore flags to their default values (Closed)
Patch Set: remove the workaround Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_network_transaction_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_protocol_test.cc
diff --git a/net/quic/core/quic_protocol_test.cc b/net/quic/core/quic_protocol_test.cc
index b2bc2bbedd92b0ef78956fb384699b9797255789..21ea85ff5c6ab1b3cd14f6492af3e0aba04e36fd 100644
--- a/net/quic/core/quic_protocol_test.cc
+++ b/net/quic/core/quic_protocol_test.cc
@@ -9,6 +9,7 @@
#include "base/stl_util.h"
#include "net/quic/core/quic_flags.h"
#include "net/quic/core/quic_utils.h"
+#include "net/quic/test_tools/quic_test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace net {
@@ -284,6 +285,12 @@ TEST(QuicProtocolTest, PathCloseFrameToString) {
}
TEST(QuicProtocolTest, FilterSupportedVersions) {
+ ValueRestore<bool> old_v35_flag(&FLAGS_quic_enable_version_35,
+ FLAGS_quic_enable_version_35);
+ ValueRestore<bool> old_v36_flag(&FLAGS_quic_enable_version_36,
+ FLAGS_quic_enable_version_36);
+ ValueRestore<bool> old_v36_2_flag(&FLAGS_quic_enable_version_36_v2,
+ FLAGS_quic_enable_version_36_v2);
QuicVersionVector all_versions = {
QUIC_VERSION_30, QUIC_VERSION_31, QUIC_VERSION_32, QUIC_VERSION_33,
QUIC_VERSION_34, QUIC_VERSION_35, QUIC_VERSION_36};
@@ -300,6 +307,10 @@ TEST(QuicProtocolTest, FilterSupportedVersions) {
}
TEST(QuicProtocolTest, QuicVersionManager) {
+ ValueRestore<bool> old_v35_flag(&FLAGS_quic_enable_version_35,
+ FLAGS_quic_enable_version_35);
+ ValueRestore<bool> old_v36_2_flag(&FLAGS_quic_enable_version_36_v2,
+ FLAGS_quic_enable_version_36_v2);
FLAGS_quic_enable_version_35 = false;
FLAGS_quic_enable_version_36_v2 = false;
QuicVersionManager manager(AllSupportedVersions());
« no previous file with comments | « net/quic/chromium/quic_network_transaction_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698