Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2293613002: Add new HTTP/2 and HPACK decoder in net/http2/. (Closed)

Created:
4 years, 3 months ago by Bence
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Hamilton
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new HTTP/2 and HPACK decoder in net/http2/. A follow-up CL will add flags and new classes to net/spdy that will benefit from this new implementation. This CL lands all server changes in the http2 directory up to 129999723 by jamessynge. BUG=488484 Committed: https://crrev.com/167743e8a7af542f317afde21d4ba19adc5b1f8f Cr-Commit-Position: refs/heads/master@{#436466}

Patch Set 1 #

Patch Set 2 : Fix build targets. #

Patch Set 3 : Fix a bunch of compile errors. #

Patch Set 4 : Fix some more compile errors. #

Patch Set 5 : And some more compile errors and test failures. #

Patch Set 6 : Fix more compile errors. #

Patch Set 7 : Rebase. #

Patch Set 8 : More. #

Patch Set 9 : More. #

Patch Set 10 : Yet another one of those signed int -> signed char truncation errors. #

Patch Set 11 : Rebase+nit. #

Patch Set 12 : Move NOTREACHED() from default to after switch; git cl format. #

Patch Set 13 : Revert changes in net/spdy. #

Patch Set 14 : Restore RandomBase in Randomize signatures. #

Patch Set 15 : Use =default for FrameParts copy constructor. #

Patch Set 16 : Remove !defined(NDEBUG) conditional from tests. #

Patch Set 17 : Revert "Remove !defined(NDEBUG) conditional from tests." #

Patch Set 18 : Rebase. #

Patch Set 19 : Replace LOG(INFO) by VLOG(2) in DecodeBufferTest.SlowDecodeTestStruct so that trybots do not fail. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19867 lines, -0 lines) Patch
A net/http2/decoder/decode_buffer.h View 1 chunk +289 lines, -0 lines 0 comments Download
A net/http2/decoder/decode_buffer.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A net/http2/decoder/decode_buffer_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +406 lines, -0 lines 0 comments Download
A net/http2/decoder/decode_http2_structures.h View 1 chunk +94 lines, -0 lines 0 comments Download
A net/http2/decoder/decode_http2_structures.cc View 1 chunk +355 lines, -0 lines 0 comments Download
A net/http2/decoder/decode_http2_structures_test.cc View 1 2 3 4 5 6 7 1 chunk +542 lines, -0 lines 0 comments Download
A net/http2/decoder/decode_status.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A net/http2/decoder/decode_status.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A net/http2/decoder/frame_decoder_state.h View 1 2 1 chunk +252 lines, -0 lines 0 comments Download
A net/http2/decoder/frame_decoder_state.cc View 1 chunk +81 lines, -0 lines 0 comments Download
A net/http2/decoder/frame_decoder_state_test_util.h View 1 chunk +36 lines, -0 lines 0 comments Download
A net/http2/decoder/frame_decoder_state_test_util.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A net/http2/decoder/frame_parts.h View 1 2 3 4 5 6 7 1 chunk +176 lines, -0 lines 0 comments Download
A net/http2/decoder/frame_parts.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +527 lines, -0 lines 0 comments Download
A net/http2/decoder/frame_parts_collector.h View 1 chunk +116 lines, -0 lines 0 comments Download
A net/http2/decoder/frame_parts_collector.cc View 1 chunk +112 lines, -0 lines 0 comments Download
A net/http2/decoder/frame_parts_collector_listener.h View 1 chunk +83 lines, -0 lines 0 comments Download
A net/http2/decoder/frame_parts_collector_listener.cc View 1 chunk +230 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_frame_decoder.h View 1 chunk +203 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_frame_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +426 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_frame_decoder_listener.h View 1 chunk +356 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_frame_decoder_listener.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +14 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_frame_decoder_listener_test_util.h View 1 chunk +141 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_frame_decoder_listener_test_util.cc View 1 chunk +485 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_frame_decoder_test.cc View 1 2 3 4 5 6 7 1 chunk +946 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_structure_decoder.h View 1 2 1 chunk +129 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_structure_decoder.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_structure_decoder_test.cc View 1 2 3 4 5 6 7 1 chunk +512 lines, -0 lines 0 comments Download
A net/http2/decoder/http2_structure_decoder_test_util.h View 1 chunk +30 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/altsvc_payload_decoder.h View 1 chunk +64 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/altsvc_payload_decoder.cc View 1 2 3 4 1 chunk +143 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/altsvc_payload_decoder_test.cc View 1 chunk +133 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/continuation_payload_decoder.h View 1 chunk +31 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/continuation_payload_decoder.cc View 1 chunk +58 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/continuation_payload_decoder_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +94 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/data_payload_decoder.h View 1 chunk +54 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/data_payload_decoder.cc View 1 2 1 chunk +123 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/data_payload_decoder_test.cc View 1 chunk +120 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/goaway_payload_decoder.h View 1 chunk +66 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/goaway_payload_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +118 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/goaway_payload_decoder_test.cc View 1 chunk +122 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/headers_payload_decoder.h View 1 chunk +67 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/headers_payload_decoder.cc View 1 chunk +173 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/headers_payload_decoder_test.cc View 1 chunk +173 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/payload_decoder_base_test_util.h View 1 2 3 4 1 chunk +486 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/payload_decoder_base_test_util.cc View 1 chunk +98 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/ping_payload_decoder.h View 1 chunk +43 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/ping_payload_decoder.cc View 1 chunk +89 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/ping_payload_decoder_test.cc View 1 chunk +122 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/priority_payload_decoder.h View 1 chunk +44 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/priority_payload_decoder.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/priority_payload_decoder_test.cc View 1 chunk +100 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/push_promise_payload_decoder.h View 1 chunk +66 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/push_promise_payload_decoder.cc View 1 chunk +172 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/push_promise_payload_decoder_test.cc View 1 chunk +151 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/rst_stream_payload_decoder.h View 1 chunk +42 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/rst_stream_payload_decoder.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/rst_stream_payload_decoder_test.cc View 1 chunk +102 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/settings_payload_decoder.h View 1 chunk +54 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/settings_payload_decoder.cc View 1 chunk +97 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/settings_payload_decoder_test.cc View 1 chunk +176 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/unknown_payload_decoder.h View 1 chunk +33 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/unknown_payload_decoder.cc View 1 chunk +55 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/unknown_payload_decoder_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +108 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/window_update_payload_decoder.h View 1 chunk +42 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/window_update_payload_decoder.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A net/http2/decoder/payload_decoders/window_update_payload_decoder_test.cc View 1 chunk +106 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_block_collector.h View 1 chunk +128 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_block_collector.cc View 1 chunk +154 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_block_decoder.h View 1 chunk +69 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_block_decoder.cc View 1 chunk +65 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_block_decoder_test.cc View 1 chunk +315 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_decoder_string_buffer.h View 1 chunk +82 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_decoder_string_buffer.cc View 1 chunk +215 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_decoder_string_buffer_test.cc View 1 chunk +245 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_entry_collector.h View 1 2 3 4 5 6 7 1 chunk +154 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_entry_collector.cc View 1 chunk +317 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_entry_decoder.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +117 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_entry_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +233 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_entry_decoder_listener.h View 1 chunk +110 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_entry_decoder_listener.cc View 1 chunk +83 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_entry_decoder_test.cc View 1 2 3 4 5 6 7 1 chunk +244 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_entry_type_decoder.h View 1 chunk +56 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_entry_type_decoder.cc View 1 chunk +360 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_entry_type_decoder_test.cc View 1 chunk +98 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_string_collector.h View 1 2 3 4 5 6 7 1 chunk +63 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_string_collector.cc View 1 chunk +127 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_string_decoder.h View 1 2 3 1 chunk +236 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_string_decoder.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_string_decoder_listener.h View 1 chunk +62 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_string_decoder_listener.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_string_decoder_test.cc View 1 2 3 4 5 1 chunk +194 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_varint_decoder.h View 1 2 1 chunk +181 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_varint_decoder.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_varint_decoder_test.cc View 1 chunk +395 lines, -0 lines 0 comments Download
A net/http2/hpack/http2_hpack_constants.h View 1 chunk +61 lines, -0 lines 0 comments Download
A net/http2/hpack/http2_hpack_constants.cc View 1 chunk +33 lines, -0 lines 0 comments Download
A net/http2/hpack/http2_hpack_constants_test.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A net/http2/hpack/huffman/http2_hpack_huffman_decoder.h View 1 chunk +149 lines, -0 lines 0 comments Download
A net/http2/hpack/huffman/http2_hpack_huffman_decoder.cc View 1 2 3 1 chunk +542 lines, -0 lines 0 comments Download
A net/http2/hpack/huffman/http2_hpack_huffman_decoder_test.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +292 lines, -0 lines 0 comments Download
A net/http2/hpack/tools/hpack_block_builder.h View 1 chunk +95 lines, -0 lines 0 comments Download
A net/http2/hpack/tools/hpack_block_builder.cc View 1 2 3 4 5 1 chunk +84 lines, -0 lines 0 comments Download
A net/http2/hpack/tools/hpack_block_builder_test.cc View 1 2 3 4 5 6 7 1 chunk +169 lines, -0 lines 0 comments Download
A net/http2/hpack/tools/hpack_example.h View 1 chunk +32 lines, -0 lines 0 comments Download
A net/http2/hpack/tools/hpack_example.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A net/http2/http2_constants.h View 1 2 3 1 chunk +265 lines, -0 lines 0 comments Download
A net/http2/http2_constants.cc View 1 chunk +161 lines, -0 lines 0 comments Download
A net/http2/http2_constants_test.cc View 1 2 3 1 chunk +272 lines, -0 lines 0 comments Download
A net/http2/http2_constants_test_util.h View 1 chunk +40 lines, -0 lines 0 comments Download
A net/http2/http2_constants_test_util.cc View 1 2 3 1 chunk +142 lines, -0 lines 0 comments Download
A net/http2/http2_structures.h View 1 chunk +326 lines, -0 lines 0 comments Download
A net/http2/http2_structures.cc View 1 chunk +138 lines, -0 lines 0 comments Download
A net/http2/http2_structures_test.cc View 1 2 3 4 5 16 1 chunk +486 lines, -0 lines 0 comments Download
A net/http2/http2_structures_test_util.h View 1 chunk +61 lines, -0 lines 0 comments Download
A net/http2/http2_structures_test_util.cc View 1 chunk +107 lines, -0 lines 0 comments Download
A net/http2/tools/failure.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +154 lines, -0 lines 0 comments Download
A net/http2/tools/failure.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A net/http2/tools/http2_bug_tracker.h View 1 chunk +14 lines, -0 lines 0 comments Download
A net/http2/tools/http2_frame_builder.h View 1 chunk +100 lines, -0 lines 0 comments Download
A net/http2/tools/http2_frame_builder.cc View 1 chunk +182 lines, -0 lines 0 comments Download
A net/http2/tools/http2_random.h View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
A net/http2/tools/http2_random.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A net/http2/tools/random_decoder_test.h View 1 chunk +264 lines, -0 lines 0 comments Download
A net/http2/tools/random_decoder_test.cc View 1 chunk +179 lines, -0 lines 0 comments Download
M net/net.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +125 lines, -0 lines 0 comments Download

Messages

Total messages: 96 (69 generated)
Bence
Ryan: PTAL at this monster CL. Note that I'm OOO until 09-13, so there is ...
4 years, 3 months ago (2016-09-02 14:11:24 UTC) #38
Bence
Ryan: PTAL at this monster CL. Note that I'm OOO until 09-13, so there is ...
4 years, 3 months ago (2016-09-02 14:11:28 UTC) #39
Ryan Hamilton
nit: Can you fix the CL description? Right now it says, "Add net/http2/." Wow, why ...
4 years, 3 months ago (2016-09-02 18:16:44 UTC) #40
Bence
On 2016/09/02 18:16:44, Ryan Hamilton wrote: > nit: Can you fix the CL description? Right ...
4 years, 3 months ago (2016-09-02 18:31:44 UTC) #41
Ryan Hamilton
On 2016/09/02 18:31:44, Bence wrote: > On 2016/09/02 18:16:44, Ryan Hamilton wrote: > > nit: ...
4 years, 2 months ago (2016-09-26 17:58:15 UTC) #43
Bence
On 2016/09/26 17:58:15, Ryan Hamilton wrote: > On 2016/09/02 18:31:44, Bence wrote: > > On ...
4 years, 2 months ago (2016-09-26 18:10:31 UTC) #44
Ryan Hamilton
On 2016/09/26 18:10:31, Bence wrote: > Yes, we are working on it. Feel free to ...
4 years, 2 months ago (2016-09-26 18:41:04 UTC) #45
James Synge
On 2016/09/26 18:41:04, Ryan Hamilton wrote: > On 2016/09/26 18:10:31, Bence wrote: > > Yes, ...
4 years ago (2016-12-02 20:26:51 UTC) #57
James Synge
On 2016/12/02 20:26:51, jamessynge wrote: > On 2016/09/26 18:41:04, Ryan Hamilton wrote: > > On ...
4 years ago (2016-12-02 20:27:38 UTC) #58
Bence
Ryan: James reviewed this CL. Please rubber stamp. Thank you.
4 years ago (2016-12-02 20:55:34 UTC) #60
Ryan Hamilton
lgtm WOOT
4 years ago (2016-12-02 22:44:04 UTC) #61
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293613002/340001
4 years ago (2016-12-02 22:57:56 UTC) #63
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/174919) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
4 years ago (2016-12-02 23:03:48 UTC) #65
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293613002/360001
4 years ago (2016-12-05 14:05:00 UTC) #68
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/347761)
4 years ago (2016-12-05 14:39:04 UTC) #70
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293613002/400001
4 years ago (2016-12-06 00:01:06 UTC) #81
commit-bot: I haz the power
Committed patchset #19 (id:400001)
4 years ago (2016-12-06 00:09:10 UTC) #84
commit-bot: I haz the power
Patchset 19 (id:??) landed as https://crrev.com/167743e8a7af542f317afde21d4ba19adc5b1f8f Cr-Commit-Position: refs/heads/master@{#436466}
4 years ago (2016-12-06 00:11:19 UTC) #86
findit-for-me
FYI: Findit identified this CL at revision 436466 as the culprit for failures in the ...
4 years ago (2016-12-06 01:10:41 UTC) #87
carlosk
A revert of this CL (patchset #19 id:400001) has been created in https://codereview.chromium.org/2554683003/ by carlosk@chromium.org. ...
4 years ago (2016-12-06 01:50:37 UTC) #88
Adam Rice
A revert of this CL (patchset #19 id:400001) has been created in https://codereview.chromium.org/2551123003/ by ricea@chromium.org. ...
4 years ago (2016-12-06 01:59:22 UTC) #89
James Synge
On 2016/12/06 01:59:22, Adam Rice wrote: > A revert of this CL (patchset #19 id:400001) ...
4 years ago (2016-12-06 02:25:50 UTC) #90
Bence
Builder failures that I am aware of (all with net_unittest failures) due to this CL ...
4 years ago (2016-12-06 13:16:23 UTC) #91
Bence
Oh and of course thank you both for reverting, and sorry for the hassle.
4 years ago (2016-12-06 13:16:53 UTC) #92
Bence
Three more: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/55328 https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/55329 https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/55330
4 years ago (2016-12-06 13:56:55 UTC) #93
Bence
Re-landing at https://crrev.com/2552703004 with DecodeBufferDeathTest.NonNullBufferRequired disabled.
4 years ago (2016-12-06 15:25:41 UTC) #95
James Synge
4 years ago (2016-12-06 16:43:27 UTC) #96
Message was sent while issue was closed.
On 2016/12/06 15:25:41, Bence wrote:
> Re-landing at https://crrev.com/2552703004 with
> DecodeBufferDeathTest.NonNullBufferRequired disabled.

FYI, we determined that the problem is that (on the failing platform only)
CHECK_NE(char*, nullptr) handles failure by producing a message as if the first
param were a string, when in fact we can say definitively that it is a nullptr
since CHECK_NE failed (i.e. the char* ptr was == nullptr). It then tries to
produce a string for printing the value of the char* ptr by dereferencing it,
which is completely wrong. Sigh.

Powered by Google App Engine
This is Rietveld 408576698