Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2292963004: Make verdict optional in csd proto. (Closed)

Created:
4 years, 3 months ago by vakh (use Gerrit instead)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, francois_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Since the verdict field is currently marked as 'required', whenever Chrome (or Firefox) can't parse this field properly, it leads to an overall failure in parsing the entire proto message. Making it optional with a default value (SAFE) solves that problem. See: cl/131841696 BUG= Committed: https://crrev.com/1596433b53b1829f1a28306d0a995fe285afe926 Cr-Commit-Position: refs/heads/master@{#415771}

Patch Set 1 #

Patch Set 2 : Update the unit test to use SAFE as the default value when encountering an invalid value. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/safe_browsing/csd.proto View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
vakh (use Gerrit instead)
4 years, 3 months ago (2016-08-31 17:33:06 UTC) #4
Jialiu Lin
lgtm
4 years, 3 months ago (2016-08-31 17:43:54 UTC) #5
vakh (use Gerrit instead)
Update the unit test to use SAFE as the default value when encountering an invalid ...
4 years, 3 months ago (2016-08-31 21:18:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292963004/20001
4 years, 3 months ago (2016-08-31 21:24:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 22:06:24 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:09:12 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1596433b53b1829f1a28306d0a995fe285afe926
Cr-Commit-Position: refs/heads/master@{#415771}

Powered by Google App Engine
This is Rietveld 408576698