chrome/common/safe_browsing/csd.proto - Issue 2292963004: Make verdict optional in csd proto.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 2292963004: Make verdict optional in csd proto. (Closed)

Patch Set: Update the unit test to use SAFE as the default value when encountering an invalid value. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/safe_browsing/csd.proto

diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto

index f2dadfd9d4850d518b2d4b185c35ab58f7de4c01..1eb1eedd69bec640c05b9d4c015a3bc9cf3d2b48 100644

--- a/chrome/common/safe_browsing/csd.proto

+++ b/chrome/common/safe_browsing/csd.proto

@@ -400,7 +400,7 @@ message ClientDownloadResponse {

// Chrome should show the default warning if configured for this file type.

UNKNOWN = 5;

}

- required Verdict verdict = 1;

+ optional Verdict verdict = 1 [default = SAFE];

message MoreInfo {

// A human-readable string describing the nature of the warning.

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | no next file » | no next file with comments »