Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Side by Side Diff: chrome/common/safe_browsing/csd.proto

Issue 2292963004: Make verdict optional in csd proto. (Closed)
Patch Set: Update the unit test to use SAFE as the default value when encountering an invalid value. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This proto file includes: 5 // This proto file includes:
6 // (1) Client side phishing and malware detection request and response 6 // (1) Client side phishing and malware detection request and response
7 // protocol buffers. Those protocol messages should be kept in sync 7 // protocol buffers. Those protocol messages should be kept in sync
8 // with the server implementation. 8 // with the server implementation.
9 // 9 //
10 // (2) Safe Browsing reporting protocol buffers. 10 // (2) Safe Browsing reporting protocol buffers.
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 // Download is uncommon. Chrome should display a less severe warning. 393 // Download is uncommon. Chrome should display a less severe warning.
394 UNCOMMON = 2; 394 UNCOMMON = 2;
395 // The download is potentially unwanted. 395 // The download is potentially unwanted.
396 POTENTIALLY_UNWANTED = 3; 396 POTENTIALLY_UNWANTED = 3;
397 // The download is from a dangerous host. 397 // The download is from a dangerous host.
398 DANGEROUS_HOST = 4; 398 DANGEROUS_HOST = 4;
399 // The backend doesn't have confidence in its verdict of this file. 399 // The backend doesn't have confidence in its verdict of this file.
400 // Chrome should show the default warning if configured for this file type. 400 // Chrome should show the default warning if configured for this file type.
401 UNKNOWN = 5; 401 UNKNOWN = 5;
402 } 402 }
403 required Verdict verdict = 1; 403 optional Verdict verdict = 1 [default = SAFE];
404 404
405 message MoreInfo { 405 message MoreInfo {
406 // A human-readable string describing the nature of the warning. 406 // A human-readable string describing the nature of the warning.
407 // Only if verdict != SAFE. Localized based on request.locale. 407 // Only if verdict != SAFE. Localized based on request.locale.
408 optional string description = 1; 408 optional string description = 1;
409 409
410 // A URL to get more information about this warning, if available. 410 // A URL to get more information about this warning, if available.
411 optional string url = 2; 411 optional string url = 2;
412 } 412 }
413 optional MoreInfo more_info = 2; 413 optional MoreInfo more_info = 2;
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
791 optional bool did_proceed = 8; 791 optional bool did_proceed = 8;
792 792
793 // Whether user visited this origin before. 793 // Whether user visited this origin before.
794 optional bool repeat_visit = 9; 794 optional bool repeat_visit = 9;
795 795
796 // The same token in ClientDownloadResponse. This field is only set if its 796 // The same token in ClientDownloadResponse. This field is only set if its
797 // report type is DANGEROUS_DOWNLOAD_RECOVERY, DANGEROUS_DOWNLOAD_WARNING or 797 // report type is DANGEROUS_DOWNLOAD_RECOVERY, DANGEROUS_DOWNLOAD_WARNING or
798 // DANGEROUS_DOWNLOAD_BY_API. 798 // DANGEROUS_DOWNLOAD_BY_API.
799 optional bytes token = 15; 799 optional bytes token = 15;
800 } 800 }
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698