Move remaining Blimp feature code to core.

Move remaining Blimp feature code to core.

Migrate the last two features (render widget and settings) from blimp/client/features to blimp/client/core.  This required adding support for BlimpCompositorDependencies throughout blimp/client/core and exposing a CompositorDependencies class in the constructor of BlimpClientContext as well.

BUG=611105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f
Cr-Commit-Position: refs/heads/master@{#415642}

[David Trainor- moved to gerrit, 2016-08-30 23:35:54]

Description was changed from

==========
Move the world around...

BUG=
==========

to

==========
Move the world around...

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[David Trainor- moved to gerrit, 2016-08-30 23:37:05]

Description was changed from

==========
Move the world around...

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Move remaining Blimp feature code to core.

Migrate the last two features (render widget and settings) from
blimp/client/features to blimp/client/core.  This required adding support for
BlimpCompositorDependencies throughout blimp/client/core and exposing a
CompositorDependencies class in the constructor of BlimpClientContext as well.

BUG=611105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[David Trainor- moved to gerrit, 2016-08-31 00:34:13]

dtrainor@chromium.org changed reviewers:
+ khushalsagar@chromium.org, nyquist@chromium.org

[David Trainor- moved to gerrit, 2016-08-31 00:34:14]

halp!  ptal

[David Trainor- moved to gerrit, 2016-08-31 00:34:51]

dtrainor@chromium.org changed reviewers:
+ vmpstr@chromium.org

[David Trainor- moved to gerrit, 2016-08-31 00:34:52]

vmpstr@: ptal at cc/ thanks!

[David Trainor- moved to gerrit, 2016-08-31 00:39:33]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 00:40:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2016-08-31 00:41:07]

cc lgtm

[commit-bot: I haz the power, 2016-08-31 00:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 00:43:47]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[David Trainor- moved to gerrit, 2016-08-31 01:42:24]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 01:42:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 01:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 01:47:44]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Trainor- moved to gerrit, 2016-08-31 03:47:27]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 03:47:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 03:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 03:52:11]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-08-31 04:30:47]

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/blim...
File blimp/client/core/blimp_client_context_impl.cc (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/blim...
blimp/client/core/blimp_client_context_impl.cc:63:
blimp_compositor_dependencies_(
nit: prefer MakeUnique.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/blim...
File blimp/client/core/blimp_client_context_impl.h (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/blim...
blimp/client/core/blimp_client_context_impl.h:10: #include "base/command_line.h"
Is the include needed?

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/blim...
blimp/client/core/blimp_client_context_impl.h:100: // |delegate_| provides the
embedder dependencies to this class when set.
We just get it in the ctor. Don't need to ask the |delegate_| really.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/cont...
File blimp/client/core/contents/blimp_contents_impl.cc (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/cont...
blimp/client/core/contents/blimp_contents_impl.cc:27:
BlimpContentsImpl::BlimpContentsImpl(
Add a method to show/hide the BlimpContents and forward to the
BlimpCompositorManager?

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/cont...
blimp/client/core/contents/blimp_contents_impl.cc:35:
compositor_manager_(render_widget_feature, compositor_deps),
Now that we have this, we can set the layer correctly on the ViewAndroid in
BlimpContentsViewAndroid.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/cont...
File blimp/client/core/contents/blimp_contents_manager.h (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/cont...
blimp/client/core/contents/blimp_contents_manager.h:8: #include <map>
Do you need these?

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
File blimp/client/core/input/BUILD.gn (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
blimp/client/core/input/BUILD.gn:16: "//blimp/client/public:public_headers",
Do we need the public_headers?

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
blimp/client/core/input/BUILD.gn:18: "//gpu/command_buffer/client",
And this?

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
blimp/client/core/input/BUILD.gn:19: "//third_party/libwebp",
And this?

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
File blimp/client/core/input/blimp_input_manager.h (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
blimp/client/core/input/blimp_input_manager.h:20: }
// namespace cc

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/session/b...
File blimp/client/session/blimp_client_session.cc (left):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/session/b...
blimp/client/session/blimp_client_session.cc:123:
settings_feature_->set_outgoing_message_processor(
We still need this in the app right?

[David Trainor- moved to gerrit, 2016-08-31 05:21:27]

addressed comments thanks!

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/blim...
File blimp/client/core/blimp_client_context_impl.cc (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/blim...
blimp/client/core/blimp_client_context_impl.cc:63:
blimp_compositor_dependencies_(
On 2016/08/31 04:30:47, Khushal wrote:
> nit: prefer MakeUnique.

Done.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/blim...
File blimp/client/core/blimp_client_context_impl.h (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/blim...
blimp/client/core/blimp_client_context_impl.h:10: #include "base/command_line.h"
On 2016/08/31 04:30:47, Khushal wrote:
> Is the include needed?

Oops meant to add it to the .cc file thanks

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/blim...
blimp/client/core/blimp_client_context_impl.h:100: // |delegate_| provides the
embedder dependencies to this class when set.
On 2016/08/31 04:30:47, Khushal wrote:
> We just get it in the ctor. Don't need to ask the |delegate_| really.

Done.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/cont...
File blimp/client/core/contents/blimp_contents_impl.cc (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/cont...
blimp/client/core/contents/blimp_contents_impl.cc:27:
BlimpContentsImpl::BlimpContentsImpl(
On 2016/08/31 04:30:47, Khushal wrote:
> Add a method to show/hide the BlimpContents and forward to the
> BlimpCompositorManager?

Done.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/cont...
blimp/client/core/contents/blimp_contents_impl.cc:35:
compositor_manager_(render_widget_feature, compositor_deps),
On 2016/08/31 04:30:47, Khushal wrote:
> Now that we have this, we can set the layer correctly on the ViewAndroid in
> BlimpContentsViewAndroid.

Done.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/cont...
File blimp/client/core/contents/blimp_contents_manager.h (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/cont...
blimp/client/core/contents/blimp_contents_manager.h:8: #include <map>
On 2016/08/31 04:30:47, Khushal wrote:
> Do you need these?

Done.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
File blimp/client/core/input/BUILD.gn (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
blimp/client/core/input/BUILD.gn:16: "//blimp/client/public:public_headers",
On 2016/08/31 04:30:47, Khushal wrote:
> Do we need the public_headers?

Done.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
blimp/client/core/input/BUILD.gn:18: "//gpu/command_buffer/client",
On 2016/08/31 04:30:47, Khushal wrote:
> And this?

Done.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
blimp/client/core/input/BUILD.gn:19: "//third_party/libwebp",
On 2016/08/31 04:30:47, Khushal wrote:
> And this?

Done.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
File blimp/client/core/input/blimp_input_manager.h (right):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/core/inpu...
blimp/client/core/input/blimp_input_manager.h:20: }
On 2016/08/31 04:30:47, Khushal wrote:
> // namespace cc

Done.

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/session/b...
File blimp/client/session/blimp_client_session.cc (left):

https://codereview.chromium.org/2292723003/diff/120001/blimp/client/session/b...
blimp/client/session/blimp_client_session.cc:123:
settings_feature_->set_outgoing_message_processor(
On 2016/08/31 04:30:47, Khushal wrote:
> We still need this in the app right?

... maybe

[Khushal, 2016-08-31 05:39:18]

lgtm. Thanks!

[nyquist, 2016-08-31 05:44:40]

lgtm! awesome!

https://codereview.chromium.org/2292723003/diff/140001/blimp/client/core/cont...
File blimp/client/core/contents/blimp_contents_impl.h (right):

https://codereview.chromium.org/2292723003/diff/140001/blimp/client/core/cont...
blimp/client/core/contents/blimp_contents_impl.h:78: BlimpCompositorManager
compositor_manager_;
Nit: Should there be a comment explaining what this is responsible for?

[David Trainor- moved to gerrit, 2016-08-31 05:55:41]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 05:55:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2016-08-31 06:49:06]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 06:49:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2016-08-31 06:49:33]

https://codereview.chromium.org/2292723003/diff/140001/blimp/client/core/cont...
File blimp/client/core/contents/blimp_contents_impl.h (right):

https://codereview.chromium.org/2292723003/diff/140001/blimp/client/core/cont...
blimp/client/core/contents/blimp_contents_impl.h:78: BlimpCompositorManager
compositor_manager_;
On 2016/08/31 05:44:40, nyquist wrote:
> Nit: Should there be a comment explaining what this is responsible for?

Done.

[commit-bot: I haz the power, 2016-08-31 07:17:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 07:17:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[David Trainor- moved to gerrit, 2016-08-31 07:26:40]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 07:26:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 08:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 08:59:49]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-08-31 15:45:13]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2016-08-31 15:45:14]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org,
nyquist@chromium.org, khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/2292723003/#ps200001
(title: "Fix build break")

[commit-bot: I haz the power, 2016-08-31 15:45:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 15:52:15]

Description was changed from

==========
Move remaining Blimp feature code to core.

Migrate the last two features (render widget and settings) from
blimp/client/features to blimp/client/core.  This required adding support for
BlimpCompositorDependencies throughout blimp/client/core and exposing a
CompositorDependencies class in the constructor of BlimpClientContext as well.

BUG=611105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Move remaining Blimp feature code to core.

Migrate the last two features (render widget and settings) from
blimp/client/features to blimp/client/core.  This required adding support for
BlimpCompositorDependencies throughout blimp/client/core and exposing a
CompositorDependencies class in the constructor of BlimpClientContext as well.

BUG=611105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-31 15:52:16]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-08-31 15:53:53]

Description was changed from

==========
Move remaining Blimp feature code to core.

Migrate the last two features (render widget and settings) from
blimp/client/features to blimp/client/core.  This required adding support for
BlimpCompositorDependencies throughout blimp/client/core and exposing a
CompositorDependencies class in the constructor of BlimpClientContext as well.

BUG=611105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Move remaining Blimp feature code to core.

Migrate the last two features (render widget and settings) from
blimp/client/features to blimp/client/core.  This required adding support for
BlimpCompositorDependencies throughout blimp/client/core and exposing a
CompositorDependencies class in the constructor of BlimpClientContext as well.

BUG=611105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f
Cr-Commit-Position: refs/heads/master@{#415642}
==========

[commit-bot: I haz the power, 2016-08-31 15:53:55]

Patchset 11 (id:??) landed as
https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f
Cr-Commit-Position: refs/heads/master@{#415642}