Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2775)

Unified Diff: blimp/client/feature/settings_feature.cc

Issue 2292723003: Move remaining Blimp feature code to core. (Closed)
Patch Set: Fix build break Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/feature/settings_feature.cc
diff --git a/blimp/client/feature/settings_feature.cc b/blimp/client/feature/settings_feature.cc
deleted file mode 100644
index f613cda6a56cbe653809bd99a0a7383ace5a2edd..0000000000000000000000000000000000000000
--- a/blimp/client/feature/settings_feature.cc
+++ /dev/null
@@ -1,53 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "blimp/client/feature/settings_feature.h"
-
-#include "blimp/common/create_blimp_message.h"
-#include "blimp/common/proto/blimp_message.pb.h"
-#include "blimp/common/proto/settings.pb.h"
-#include "net/base/net_errors.h"
-
-namespace blimp {
-namespace client {
-
-SettingsFeature::SettingsFeature() : record_whole_document_(false) {}
-
-SettingsFeature::~SettingsFeature() {}
-
-void SettingsFeature::set_outgoing_message_processor(
- std::unique_ptr<BlimpMessageProcessor> processor) {
- outgoing_message_processor_ = std::move(processor);
-}
-
-void SettingsFeature::SetRecordWholeDocument(bool record_whole_document) {
- if (record_whole_document_ == record_whole_document)
- return;
-
- record_whole_document_ = record_whole_document;
-
- EngineSettingsMessage* engine_settings;
- std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&engine_settings);
- engine_settings->set_record_whole_document(record_whole_document_);
- outgoing_message_processor_->ProcessMessage(std::move(message),
- net::CompletionCallback());
-}
-
-void SettingsFeature::SendUserAgentOSVersionInfo(const std::string& osVersion) {
- EngineSettingsMessage* engine_settings;
- std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&engine_settings);
- engine_settings->set_client_os_info(osVersion);
- outgoing_message_processor_->ProcessMessage(std::move(message),
- net::CompletionCallback());
-}
-
-void SettingsFeature::ProcessMessage(std::unique_ptr<BlimpMessage> message,
- const net::CompletionCallback& callback) {
- // We don't receive any messages from the engine yet.
- NOTREACHED() << "Invalid settings message received from the engine.";
- callback.Run(net::OK);
-}
-
-} // namespace client
-} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698