Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: blimp/client/core/settings/BUILD.gn

Issue 2292723003: Move remaining Blimp feature code to core. (Closed)
Patch Set: Fix build break Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/settings/BUILD.gn
diff --git a/blimp/client/core/settings/BUILD.gn b/blimp/client/core/settings/BUILD.gn
index 54eb8716a9c4f53e6b1b946fec8b0a2f27d7a832..8e1b53a4a10370acfe98afcb1b07173ca1e516c0 100644
--- a/blimp/client/core/settings/BUILD.gn
+++ b/blimp/client/core/settings/BUILD.gn
@@ -5,22 +5,41 @@
if (is_android) {
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")
+}
- source_set("settings") {
- visibility = [ "//blimp/client/*" ]
+source_set("settings") {
+ visibility = [ "//blimp/client/*" ]
- sources = [
+ sources = [
+ "settings_feature.cc",
+ "settings_feature.h",
+ ]
+
+ deps = [
+ "//blimp/common",
+ "//net",
+ ]
+
+ public_deps = [
+ "//base",
+ "//blimp/net",
+ ]
+
+ if (is_android) {
+ sources += [
"android/blimp_settings_android.cc",
"android/blimp_settings_android.h",
]
- deps = [
+ deps += [
":settings_jni_headers",
"//blimp/client/core/session",
"//blimp/common",
]
}
+}
+if (is_android) {
android_library("settings_java") {
visibility = [ "//blimp/client/*" ]
« no previous file with comments | « blimp/client/core/render_widget/render_widget_feature_unittest.cc ('k') | blimp/client/core/settings/settings_feature.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698