chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 2292723003: Move remaining Blimp feature code to core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2292723003: Move remaining Blimp feature code to core. (Closed)

Patch Set: Fix build break Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index 6ae4ba3efe7603b59a09ba9506a3edcd8d77d2b9..73ec097c3c6ef119e117bed07fc18c874abed37d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -1352,6 +1352,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

assert !isFrozen();

if (mContentViewCore != null) mContentViewCore.onShow();

+ if (mBlimpContents != null) mBlimpContents.show();

if (mTabUma != null) {

mTabUma.onShow(type, getTimestampMillis(),

@@ -1391,6 +1392,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

mIsHidden = true;

if (mContentViewCore != null) mContentViewCore.onHide();

+ if (mBlimpContents != null) mBlimpContents.hide();

// Clean up any fullscreen state that might impact other tabs.

if (mFullscreenManager != null) {