[inspector] Build inspector under v8_enable_inspector build flag.

[inspector] Build inspector under v8_enable_inspector build flag.

- inspector becomes a dependency of v8_base;
- generated public protocol files are placed to gen/v8/include/inspector/<Domain.h>;
- added v8_enable_inspector_override to be used in embedders (gn only);
- combined public headers into v8-inspector.h and v8-inspector-protocol.h.

BUG=chromium:635948
Committed: https://crrev.com/81b7e77ff02189bf7d4d4b86e1ebd666960cbe51
Cr-Commit-Position: refs/heads/master@{#39226}

[dgozman, 2016-09-01 22:24:29]

Description was changed from

==========
[inspector] Build inspector under v8_enable_inspector build flag.

- inspector becomes a dependency of v8_base;
- generated public protocol files are placed to
gen/v8/include/inspector/<Domain.h>;
- added v8_enable_inspector_override to be used in embedders;
- combined public headers into v8-inspector.h, clang-formatted them.

BUG=chromium:635948
==========

to

==========
[inspector] Build inspector under v8_enable_inspector build flag.

- inspector becomes a dependency of v8_base;
- generated public protocol files are placed to
gen/v8/include/inspector/<Domain.h>;
- added v8_enable_inspector_override to be used in embedders (gn only);
- combined public headers into v8-inspector.h and v8-inspector-protocol.h.

BUG=chromium:635948
==========

[dgozman, 2016-09-01 22:43:47]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 22:43:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 22:56:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 22:56:01]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[dgozman, 2016-09-01 23:30:39]

dgozman@chromium.org changed reviewers:
+ jochen@chromium.org, machenbach@chromium.org, pfeldman@chromium.org

[dgozman, 2016-09-01 23:30:40]

Could you please take a look? Any suggestions are welcome!

[dgozman, 2016-09-01 23:31:52]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 23:32:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 23:38:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 23:38:32]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Michael Achenbach, 2016-09-02 07:21:28]

https://codereview.chromium.org/2292053003/diff/160001/build_overrides/v8.gni
File build_overrides/v8.gni (right):

https://codereview.chromium.org/2292053003/diff/160001/build_overrides/v8.gni...
build_overrides/v8.gni:32: v8_enable_inspector_override = v8_enable_inspector
The last line should land in chromium's v8.gni first with a chromium default.

[dgozman, 2016-09-02 14:05:59]

https://codereview.chromium.org/2292053003/diff/160001/build_overrides/v8.gni
File build_overrides/v8.gni (right):

https://codereview.chromium.org/2292053003/diff/160001/build_overrides/v8.gni...
build_overrides/v8.gni:32: v8_enable_inspector_override = v8_enable_inspector
On 2016/09/02 07:21:28, machenbach (slow) wrote:
> The last line should land in chromium's v8.gni first with a chromium default.

Sure! I want to get a review of this patch first though, so that everyone
interested is fine with the plan.

[pfeldman, 2016-09-03 01:13:38]

I bless this! Rock'n'roll! LGTM!

[Michael Achenbach, 2016-09-05 06:40:34]

buil-system lgtm with comment:

https://codereview.chromium.org/2292053003/diff/160001/src/v8.gyp
File src/v8.gyp (right):

https://codereview.chromium.org/2292053003/diff/160001/src/v8.gyp#newcode1737
src/v8.gyp:1737: 'dependencies': [
Didn't see any gn equivalent of this in this CL. Not needed? Already landed?

[jochen (gone - plz use gerrit), 2016-09-05 09:46:44]

lgtm

[dgozman, 2016-09-06 17:37:35]

Thank you for review!

https://codereview.chromium.org/2292053003/diff/160001/src/v8.gyp
File src/v8.gyp (right):

https://codereview.chromium.org/2292053003/diff/160001/src/v8.gyp#newcode1737
src/v8.gyp:1737: 'dependencies': [
On 2016/09/05 06:40:34, machenbach (slow) wrote:
> Didn't see any gn equivalent of this in this CL. Not needed? Already landed?

GN achieves this by having a v8_source_set("inspector"), which depends on
similar targets. In gyp we just add all inspector sources to v8_base (as
opposite to compiling them separately in source_set), thus deps move here.

[Michael Achenbach, 2016-09-06 18:27:22]

https://codereview.chromium.org/2292053003/diff/160001/src/v8.gyp
File src/v8.gyp (right):

https://codereview.chromium.org/2292053003/diff/160001/src/v8.gyp#newcode1737
src/v8.gyp:1737: 'dependencies': [
On 2016/09/06 17:37:35, dgozman wrote:
> On 2016/09/05 06:40:34, machenbach (slow) wrote:
> > Didn't see any gn equivalent of this in this CL. Not needed? Already landed?
> 
> GN achieves this by having a v8_source_set("inspector"), which depends on
> similar targets. In gyp we just add all inspector sources to v8_base (as
> opposite to compiling them separately in source_set), thus deps move here.

Acknowledged.

[dgozman, 2016-09-06 20:52:33]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 20:52:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 21:56:28]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-09-06 23:23:13]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-06 23:23:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 23:26:14]

Description was changed from

==========
[inspector] Build inspector under v8_enable_inspector build flag.

- inspector becomes a dependency of v8_base;
- generated public protocol files are placed to
gen/v8/include/inspector/<Domain.h>;
- added v8_enable_inspector_override to be used in embedders (gn only);
- combined public headers into v8-inspector.h and v8-inspector-protocol.h.

BUG=chromium:635948
==========

to

==========
[inspector] Build inspector under v8_enable_inspector build flag.

- inspector becomes a dependency of v8_base;
- generated public protocol files are placed to
gen/v8/include/inspector/<Domain.h>;
- added v8_enable_inspector_override to be used in embedders (gn only);
- combined public headers into v8-inspector.h and v8-inspector-protocol.h.

BUG=chromium:635948
==========

[commit-bot: I haz the power, 2016-09-06 23:26:16]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-06 23:26:43]

Description was changed from

==========
[inspector] Build inspector under v8_enable_inspector build flag.

- inspector becomes a dependency of v8_base;
- generated public protocol files are placed to
gen/v8/include/inspector/<Domain.h>;
- added v8_enable_inspector_override to be used in embedders (gn only);
- combined public headers into v8-inspector.h and v8-inspector-protocol.h.

BUG=chromium:635948
==========

to

==========
[inspector] Build inspector under v8_enable_inspector build flag.

- inspector becomes a dependency of v8_base;
- generated public protocol files are placed to
gen/v8/include/inspector/<Domain.h>;
- added v8_enable_inspector_override to be used in embedders (gn only);
- combined public headers into v8-inspector.h and v8-inspector-protocol.h.

BUG=chromium:635948

Committed: https://crrev.com/81b7e77ff02189bf7d4d4b86e1ebd666960cbe51
Cr-Commit-Position: refs/heads/master@{#39226}
==========

[commit-bot: I haz the power, 2016-09-06 23:26:44]

Patchset 9 (id:??) landed as
https://crrev.com/81b7e77ff02189bf7d4d4b86e1ebd666960cbe51
Cr-Commit-Position: refs/heads/master@{#39226}